Bug 168965

Summary: [Win] Popup menus are too small in HiDPI mode.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+, bfulgham: commit-queue-

Description Per Arne Vollan 2017-02-28 04:06:05 PST 
We need to scale with the device scale factor.
Comment 1 Per Arne Vollan 2017-02-28 04:11:09 PST 
Created attachment 302931 [details]
Patch
Comment 2 Per Arne Vollan 2017-02-28 05:49:28 PST 
rdar://problem/30742143
Comment 3 Brent Fulgham 2017-02-28 10:56:54 PST 
Comment on attachment 302931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302931&action=review

R=me.

Looks good, but please consolidate that for handling code.

> Source/WebCore/platform/win/PopupMenuWin.cpp:623
> +    font.update(m_popupClient->fontSelector());

It seems like this code could be shared with the above method.
Comment 4 Per Arne Vollan 2017-03-01 00:38:02 PST 
(In reply to comment #3)
> Comment on attachment 302931 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302931&action=review
> 
> R=me.
> 
> Looks good, but please consolidate that for handling code.
> 
> > Source/WebCore/platform/win/PopupMenuWin.cpp:623
> > +    font.update(m_popupClient->fontSelector());
> 
> It seems like this code could be shared with the above method.

Thanks for reviewing! I will update the patch.
Comment 5 Per Arne Vollan 2017-03-01 00:49:43 PST 
Committed <http://trac.webkit.org/changeset/213211>.