Bug 168956

Summary: Arrow key shouldn't move the indicator beyond the visible points
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, joepeck, kling, koivisto, rniwa, slewis
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Fixes the bug joepeck: review+

Ryosuke Niwa
Reported 2017-02-27 18:00:31 PST
When pressing arrow keys on a chart pane, the indicator shouldn't move past the visible region.
Attachments
Fixes the bug (13.24 KB, patch)
2017-02-27 18:04 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes the bug (13.08 KB, patch)
2017-02-27 18:05 PST, Ryosuke Niwa 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-27 18:04:20 PST
Created attachment 302904 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2017-02-27 18:05:33 PST
Created attachment 302905 [details] Fixes the bug
Joseph Pecoraro
Comment 3 2017-02-27 19:30:28 PST
Comment on attachment 302905 [details] Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=302905&action=review r=me > Websites/perf.webkit.org/browser-tests/time-series-chart-tests.js:1770 > + Nit: unexpected empty line
Ryosuke Niwa
Comment 4 2017-02-27 19:32:25 PST
Committed r213116: <http://trac.webkit.org/changeset/213116>
Note You need to log in before you can comment on or make changes to this bug.