Bug 168951

Summary: Export WKPluginInformationBundleShortVersionKey
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, mitz, sam
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
Another proposed patch ap: review-

Alexey Proskuryakov
Reported 2017-02-27 17:05:23 PST
WKPluginInformationBundleShortVersionKey was accidentally not exported from the framework in https://trac.webkit.org/changeset/151767
Attachments
proposed patch (1.23 KB, patch)
2017-02-27 17:06 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Another proposed patch (1.98 KB, patch)
2017-02-27 17:16 PST, Aakash Jain 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2017-02-27 17:06:45 PST
Created attachment 302894 [details] proposed patch
Aakash Jain
Comment 2 2017-02-27 17:13:07 PST
Do we need the WKPluginInformationBundleShortVersionKey method at all. It doesn't seems to be used anywhere. Shouldn't we just delete it from WKPluginInformation.h and WKPluginInformation.cpp
Aakash Jain
Comment 3 2017-02-27 17:16:10 PST
Created attachment 302896 [details] Another proposed patch
Alexey Proskuryakov
Comment 4 2017-02-27 17:40:20 PST
Comment on attachment 302894 [details] proposed patch It's not used, but I think that it's better to keep for consistency. It would be strange to expose WKPluginInformationBundleVersionKey, but not WKPluginInformationBundleShortVersionKey.
WebKit Commit Bot
Comment 5 2017-02-27 18:08:09 PST
Comment on attachment 302894 [details] proposed patch Clearing flags on attachment: 302894 Committed r213111: <http://trac.webkit.org/changeset/213111>
WebKit Commit Bot
Comment 6 2017-02-27 18:08:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.