Summary: | Export WKPluginInformationBundleShortVersionKey | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, mitz, sam | ||||||
Priority: | P2 | ||||||||
Version: | Safari 9 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2017-02-27 17:05:23 PST
Created attachment 302894 [details]
proposed patch
Do we need the WKPluginInformationBundleShortVersionKey method at all. It doesn't seems to be used anywhere. Shouldn't we just delete it from WKPluginInformation.h and WKPluginInformation.cpp Created attachment 302896 [details]
Another proposed patch
Comment on attachment 302894 [details]
proposed patch
It's not used, but I think that it's better to keep for consistency. It would be strange to expose WKPluginInformationBundleVersionKey, but not WKPluginInformationBundleShortVersionKey.
Comment on attachment 302894 [details] proposed patch Clearing flags on attachment: 302894 Committed r213111: <http://trac.webkit.org/changeset/213111> All reviewed patches have been landed. Closing bug. |