Bug 168918

Summary: [Modern Media Controls] Status text does not appear on iOS
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antoine Quint
Reported 2017-02-27 11:03:03 PST
We are not showing the status text when set on iOS.
Attachments
Patch (17.52 KB, patch)
2017-02-27 11:05 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.56 KB, patch)
2017-02-27 11:17 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-27 11:03:31 PST
<rdar://problem/30737644>
Antoine Quint
Comment 2 2017-02-27 11:05:33 PST
Created attachment 302853 [details] Patch
Dean Jackson
Comment 3 2017-02-27 11:11:39 PST
Comment on attachment 302853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302853&action=review > Source/WebCore/ChangeLog:11 > + both the macOS and iOS inline media controls run the exact same layout "exact same" -> "same" > Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js:87 > + children.unshift(this._backgroundTint); This line might warrant a comment.
Antoine Quint
Comment 4 2017-02-27 11:17:09 PST
Created attachment 302855 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-02-27 11:57:01 PST
Comment on attachment 302855 [details] Patch for landing Clearing flags on attachment: 302855 Committed r213084: <http://trac.webkit.org/changeset/213084>
WebKit Commit Bot
Comment 6 2017-02-27 11:57:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.