Bug 168908

Summary:

Move MemoryPressureHandler to WTF

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Web Template Framework

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, kling, koivisto

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch for EWS	none
Patch for EWS 2	none
Patch for EWS 3	none
Patch for EWS 4	none
Patch for EWS 5	none
Patch	none

Andreas Kling

Reported 2017-02-27 02:18:33 PST

MemoryPressureHandler should live in WTF so that JavaScriptCore (and WTF itself) can use it.

Attachments
Patch for EWS (43.85 KB, patch) 2017-02-27 02:27 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for EWS 2 (44.76 KB, patch) 2017-02-27 03:33 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for EWS 3 (45.35 KB, patch) 2017-02-27 12:51 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for EWS 4 (46.07 KB, patch) 2017-02-27 14:54 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch for EWS 5 (46.75 KB, patch) 2017-02-28 02:06 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Patch (53.67 KB, patch) 2017-02-28 21:26 PST, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2017-02-27 02:27:43 PST

Created attachment 302831 [details] Patch for EWS

WebKit Commit Bot

Comment 2 2017-02-27 02:29:29 PST

Attachment 302831 [details] did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:55: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:56: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:70: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:78: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:115: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:128: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:149: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:102: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:239: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/PlatformMac.cmake:25: No trailing spaces [whitespace/trailing] [5] ERROR: Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp:28: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/PlatformGTK.cmake:15: Alphabetical sorting problem. "linux/CurrentProcessMemoryStatus.cpp" should be before "text/gtk/TextBreakIteratorInternalICUGtk.cpp". [list/order] [5] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.cpp:27: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.cpp:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:36: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:37: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 20 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 3 2017-02-27 03:33:13 PST

Created attachment 302835 [details] Patch for EWS 2

WebKit Commit Bot

Comment 4 2017-02-27 11:27:18 PST

Attachment 302835 [details] did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:70: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:78: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:115: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:128: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:149: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:39: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:237: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:36: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:37: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 13 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 5 2017-02-27 12:51:15 PST

Created attachment 302865 [details] Patch for EWS 3

WebKit Commit Bot

Comment 6 2017-02-27 12:54:09 PST

Attachment 302865 [details] did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:70: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:78: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:115: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:128: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:149: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:237: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:36: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:37: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 12 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 7 2017-02-27 14:54:10 PST

Created attachment 302876 [details] Patch for EWS 4

WebKit Commit Bot

Comment 8 2017-02-27 14:55:54 PST

Attachment 302876 [details] did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:70: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:78: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:115: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:128: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:149: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:237: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:36: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:37: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 12 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 9 2017-02-28 02:06:36 PST

Created attachment 302927 [details] Patch for EWS 5 Getting there..

WebKit Commit Bot

Comment 10 2017-02-28 02:11:05 PST

Attachment 302927 [details] did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:70: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:78: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:115: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:128: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:149: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:237: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:36: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:37: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 12 in 37 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andreas Kling

Comment 11 2017-02-28 21:26:28 PST

Created attachment 303034 [details] Patch

WebKit Commit Bot

Comment 12 2017-02-28 21:28:30 PST

Attachment 303034 [details] did not pass style-queue: ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:70: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:78: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:115: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:128: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:149: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:154: No space between ^ and block definition. [whitespace/brackets] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:100: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/linux/MemoryPressureHandlerLinux.cpp:237: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:161: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MemoryPressureHandler.h:168: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:36: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WTF/wtf/win/Win32Handle.h:37: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 12 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 13 2017-02-28 22:34:46 PST

Comment on attachment 303034 [details] Patch rs=me

WebKit Commit Bot

Comment 14 2017-03-01 01:40:38 PST

Comment on attachment 303034 [details] Patch Clearing flags on attachment: 303034 Committed r213214: <http://trac.webkit.org/changeset/213214>

WebKit Commit Bot

Comment 15 2017-03-01 01:40:43 PST

All reviewed patches have been landed. Closing bug.

Alex Christensen

Comment 16 2017-03-01 23:06:44 PST

r213269

Note You need to log in before you can comment on or make changes to this bug.