Bug 168907

Summary: [iOS] Enable file replacement
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, benjamin, cdumez, cmarcelo, commit-queue, dbates, ddkilzer, joepeck, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2017-02-27 01:57:22 PST
[iOS] Enable file replacement
Attachments
Patch (6.07 KB, patch)
2017-02-27 02:04 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (6.30 KB, patch)
2017-02-27 15:34 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-02-27 01:59:15 PST
rdar://problem/22258242
Andy Estes
Comment 2 2017-02-27 02:04:59 PST
Created attachment 302830 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2017-02-27 06:31:53 PST
Comment on attachment 302830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302830&action=review r=me > Source/WebCore/fileapi/FileMac.mm:44 > + NSURL *pathURL = [NSURL URLByResolvingAliasFileAtURL:[NSURL fileURLWithPath:path isDirectory:NO] options:NSURLBookmarkResolutionWithoutUI error:nullptr]; Would be nice to log the NSError below on failure instead of just ignoring it. > Source/WebCore/fileapi/FileMac.mm:49 > + if (![pathURL getResourceValue:&uti forKey:NSURLTypeIdentifierKey error:nullptr]) Would be nice to log the NSError below on failure instead of just ignoring it.
Andy Estes
Comment 4 2017-02-27 15:34:23 PST
Created attachment 302878 [details] Patch
WebKit Commit Bot
Comment 5 2017-02-27 16:15:17 PST
Comment on attachment 302878 [details] Patch Clearing flags on attachment: 302878 Committed r213100: <http://trac.webkit.org/changeset/213100>
WebKit Commit Bot
Comment 6 2017-02-27 16:15:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.