| Summary: | Update CSSFontSelector's matching algorithm to understand ranges | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | buildbot, dino, hyatt, jonlee, koivisto, mmaxfield, rniwa, simon.fraser, thorton | ||||||||||||||||||||||||||||||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug Blocks: | 162815 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Description
Myles C. Maxfield
2017-02-26 21:21:00 PST
Created attachment 303306 [details]
WIP
Created attachment 303307 [details]
WIP
Created attachment 303343 [details]
Builds
Created attachment 303356 [details]
WIP
Created attachment 303387 [details]
WIP
Created attachment 303407 [details]
WIP
Created attachment 303409 [details]
WIP
Created attachment 303410 [details]
WIP
Created attachment 303414 [details]
WIP
Created attachment 303417 [details]
WIP
Created attachment 303418 [details]
Patch
Created attachment 303422 [details]
Patch
Created attachment 303425 [details]
Patch
Created attachment 303426 [details]
Patch
Created attachment 303427 [details]
Patch
Created attachment 303429 [details]
Patch
Created attachment 303431 [details]
Patch
Created attachment 303434 [details]
Patch
Created attachment 303436 [details]
Patch
Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3244420 New failing tests: fast/text/font-face-javascript.html Created attachment 303439 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3244429 New failing tests: fast/text/font-face-javascript.html Created attachment 303440 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3244423 New failing tests: fast/text/font-face-javascript.html Created attachment 303441 [details]
Archive of layout-test-results from ews114 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3244434 New failing tests: fast/text/font-face-javascript.html Created attachment 303442 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 303444 [details]
Patch
Comment on attachment 303444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303444&action=review > Source/WebCore/css/CSSFontFace.cpp:222 > + return FontSelectionValue(100); Are all instances of common values like this refactored later? > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-1241 > - default: why was this removed? Comment on attachment 303444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303444&action=review >> Source/WebCore/css/CSSFontFace.cpp:222 >> + return FontSelectionValue(100); > > Are all instances of common values like this refactored later? Yes, in https://bugs.webkit.org/show_bug.cgi?id=168889 >> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-1241 >> - default: > > why was this removed? It's dead code, but I guess I could put it back to be defensive. Committed r213436: <http://trac.webkit.org/changeset/213436> Reopening to attach new patch. Created attachment 303470 [details]
WIP
|