Bug 168892

Summary:

Update CSSFontSelector's matching algorithm to understand ranges

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, dino, hyatt, jonlee, koivisto, mmaxfield, rniwa, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

162815

Attachments:

Description	Flags
WIP	none
WIP	none
Builds	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
WIP	none

Myles C. Maxfield

Reported 2017-02-26 21:21:00 PST

This is needed for @font-face to work with variation fonts

Attachments
WIP (90.74 KB, patch) 2017-03-03 01:55 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (91.76 KB, patch) 2017-03-03 02:21 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Builds (95.95 KB, patch) 2017-03-03 14:30 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (115.24 KB, patch) 2017-03-03 16:27 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (406.32 KB, patch) 2017-03-03 23:10 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (74.69 KB, patch) 2017-03-04 14:10 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (74.74 KB, patch) 2017-03-04 14:54 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (74.75 KB, patch) 2017-03-04 15:29 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (81.98 KB, patch) 2017-03-04 15:57 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (87.17 KB, patch) 2017-03-04 16:13 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (90.47 KB, patch) 2017-03-04 16:54 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (90.32 KB, patch) 2017-03-04 17:26 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (90.65 KB, patch) 2017-03-04 17:52 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (90.80 KB, patch) 2017-03-04 17:59 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (90.79 KB, patch) 2017-03-04 18:18 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (90.86 KB, patch) 2017-03-04 18:29 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (92.88 KB, patch) 2017-03-04 19:07 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (86.97 KB, patch) 2017-03-04 19:23 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (88.97 KB, patch) 2017-03-04 19:52 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (908.02 KB, application/zip) 2017-03-04 21:04 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (900.34 KB, application/zip) 2017-03-04 21:07 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.67 MB, application/zip) 2017-03-04 21:12 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (838.44 KB, application/zip) 2017-03-04 21:19 PST, Build Bot	no flags	Details
Patch (94.87 KB, patch) 2017-03-04 23:36 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (434.62 KB, patch) 2017-03-05 15:07 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (24) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-03-03 01:55:30 PST

Created attachment 303306 [details] WIP

Myles C. Maxfield

Comment 2 2017-03-03 02:21:38 PST

Created attachment 303307 [details] WIP

Myles C. Maxfield

Comment 3 2017-03-03 14:30:35 PST

Created attachment 303343 [details] Builds

Myles C. Maxfield

Comment 4 2017-03-03 16:27:45 PST

Created attachment 303356 [details] WIP

Myles C. Maxfield

Comment 5 2017-03-03 23:10:45 PST

Created attachment 303387 [details] WIP

Myles C. Maxfield

Comment 6 2017-03-04 14:10:02 PST

Created attachment 303407 [details] WIP

Myles C. Maxfield

Comment 7 2017-03-04 14:54:55 PST

Created attachment 303409 [details] WIP

Myles C. Maxfield

Comment 8 2017-03-04 15:29:45 PST

Created attachment 303410 [details] WIP

Myles C. Maxfield

Comment 9 2017-03-04 15:57:24 PST

Created attachment 303414 [details] WIP

Myles C. Maxfield

Comment 10 2017-03-04 16:13:01 PST

Created attachment 303417 [details] WIP

Myles C. Maxfield

Comment 11 2017-03-04 16:54:59 PST

Created attachment 303418 [details] Patch

Myles C. Maxfield

Comment 12 2017-03-04 17:26:15 PST

Created attachment 303422 [details] Patch

Myles C. Maxfield

Comment 13 2017-03-04 17:52:25 PST

Created attachment 303425 [details] Patch

Myles C. Maxfield

Comment 14 2017-03-04 17:59:14 PST

Created attachment 303426 [details] Patch

Myles C. Maxfield

Comment 15 2017-03-04 18:18:28 PST

Created attachment 303427 [details] Patch

Myles C. Maxfield

Comment 16 2017-03-04 18:29:19 PST

Created attachment 303429 [details] Patch

Myles C. Maxfield

Comment 17 2017-03-04 19:07:24 PST

Created attachment 303431 [details] Patch

Myles C. Maxfield

Comment 18 2017-03-04 19:23:53 PST

Created attachment 303434 [details] Patch

Myles C. Maxfield

Comment 19 2017-03-04 19:52:53 PST

Created attachment 303436 [details] Patch

Build Bot

Comment 20 2017-03-04 21:04:12 PST

Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3244420 New failing tests: fast/text/font-face-javascript.html

Build Bot

Comment 21 2017-03-04 21:04:15 PST

Created attachment 303439 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 22 2017-03-04 21:07:38 PST

Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3244429 New failing tests: fast/text/font-face-javascript.html

Build Bot

Comment 23 2017-03-04 21:07:41 PST

Created attachment 303440 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 24 2017-03-04 21:12:05 PST

Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3244423 New failing tests: fast/text/font-face-javascript.html

Build Bot

Comment 25 2017-03-04 21:12:08 PST

Created attachment 303441 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 26 2017-03-04 21:19:44 PST

Comment on attachment 303436 [details] Patch Attachment 303436 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3244434 New failing tests: fast/text/font-face-javascript.html

Build Bot

Comment 27 2017-03-04 21:19:47 PST

Created attachment 303442 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 28 2017-03-04 23:36:16 PST

Created attachment 303444 [details] Patch

Jon Lee

Comment 29 2017-03-05 11:43:39 PST

Comment on attachment 303444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303444&action=review > Source/WebCore/css/CSSFontFace.cpp:222 > + return FontSelectionValue(100); Are all instances of common values like this refactored later? > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-1241 > - default: why was this removed?

Myles C. Maxfield

Comment 30 2017-03-05 12:07:55 PST

Comment on attachment 303444 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303444&action=review >> Source/WebCore/css/CSSFontFace.cpp:222 >> + return FontSelectionValue(100); > > Are all instances of common values like this refactored later? Yes, in https://bugs.webkit.org/show_bug.cgi?id=168889 >> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:-1241 >> - default: > > why was this removed? It's dead code, but I guess I could put it back to be defensive.

Myles C. Maxfield

Comment 31 2017-03-05 12:14:11 PST

Committed r213436: <http://trac.webkit.org/changeset/213436>

Myles C. Maxfield

Comment 32 2017-03-05 15:07:03 PST

Reopening to attach new patch.

Myles C. Maxfield

Comment 33 2017-03-05 15:07:07 PST

Created attachment 303470 [details] WIP

Note You need to log in before you can comment on or make changes to this bug.