| Summary: | Don't import RetainPtr in WebNotification.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | WebKit Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, achristensen, commit-queue, joepeck, mitz, ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=136972 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Proskuryakov
2017-02-25 19:49:18 PST
Created attachment 302768 [details]
proposed fix
Comment on attachment 302768 [details] proposed fix Attachment 302768 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3194315 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html Created attachment 302772 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 302768 [details] proposed fix Clearing flags on attachment: 302768 Committed r213018: <http://trac.webkit.org/changeset/213018> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > Comment on attachment 302768 [details] > proposed fix > > Clearing flags on attachment: 302768 > > Committed r213018: <http://trac.webkit.org/changeset/213018> It broke the Apple Mac cmake build, see https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/12496 (In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 302768 [details] > > proposed fix > > > > Clearing flags on attachment: 302768 > > > > Committed r213018: <http://trac.webkit.org/changeset/213018> > > It broke the Apple Mac cmake build, see > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/12496 Alex fixed it: https://trac.webkit.org/changeset/213724/trunk/Source/WebKit/mac/WebView/WebNotification.h |