Bug 168872

Summary: Simple line layout: Move coverage functions out of SimpleLineLayout.cpp
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2017-02-25 16:17:16 PST
SimpleLineLayou.cpp should only have the core functions.
Attachments
Patch (43.47 KB, patch)
2017-02-25 16:21 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (43.58 KB, patch)
2017-02-25 20:53 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (43.62 KB, patch)
2017-02-25 22:40 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-02-25 16:21:18 PST
Created attachment 302764 [details] Patch
WebKit Commit Bot
Comment 2 2017-02-25 16:56:14 PST
Comment on attachment 302764 [details] Patch Rejecting attachment 302764 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 302764, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/3193563
zalan
Comment 3 2017-02-25 20:53:57 PST
Created attachment 302771 [details] Patch
WebKit Commit Bot
Comment 4 2017-02-25 21:26:47 PST
Comment on attachment 302771 [details] Patch Rejecting attachment 302771 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 86_64/DOMHTMLDListElement.dia -c /Volumes/Data/EWS/WebKit/Source/WebKit/mac/DOM/DOMHTMLDListElement.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKitLegacy.build/Objects-normal/x86_64/DOMHTMLDListElement.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKitLegacy.build/Objects-normal/x86_64/DOM.o mac/DOM/DOM.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/3194484
zalan
Comment 5 2017-02-25 22:40:28 PST
Created attachment 302781 [details] Patch
WebKit Commit Bot
Comment 6 2017-02-25 23:21:12 PST
Comment on attachment 302781 [details] Patch Clearing flags on attachment: 302781 Committed r213009: <http://trac.webkit.org/changeset/213009>
WebKit Commit Bot
Comment 7 2017-02-25 23:21:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.