Bug 16887

Summary:	Cannot open WebKit solution unless $WebKitLibrariesDir env var is set
Product:	WebKit	Reporter:	Brent Fulgham <bfulgham>
Component:	WebKit Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, aroben, dev+webkit, eric, sfalken
Priority:	P2	Keywords:	PlatformOnly
Version:	523.x (Safari 3)
Hardware:	PC
OS:	Windows XP

Description Brent Fulgham 2008-01-15 16:29:02 PST

Attempting to open the WebCore.vcproj in Visual Studio generates the following error:

The following error has occurred during XML parsing:

File: C:\Fulgham\WebKit\WebCore\WebCore.vcproj\WebCore.vcproj
Line: 24
Column: 4
Error Message:
Property sheet file '$(WebKitLibrariesDir)\tools\vsprops\common.vsprops' was not found or failed to load.
The file 'C:\Fulgham\WebKit\WebCore\WebCore.vcproj\WebCore.vcproj' has failed to load.

Likewise, the QTMovieWin.vcproj fails to load:

The following error has occurred during XML parsing:

File: C:\Fulgham\WebKit\WebCore\WebCore.vcproj\QTMovieWin.vcproj
Line: 23
Column: 4
Error Message:
Property sheet file '$(WebKitLibrariesDir)\tools\vsprops\common.vsprops' was not found or failed to load.
The file 'C:\Fulgham\WebKit\WebCore\WebCore.vcproj\QTMovieWin.vcproj' has failed to load.

It looks like the ZIP file "WebKitAuxiliaryLibrary.zip" needs to be updated to contain these files, or they should be added to source control so they get checked out with the rest of the sources.

Comment 1 Matt Lilek 2008-01-15 17:21:24 PST

I don't think this has anything to do with the aux libs.  Steve added these files in <http://trac.webkit.org/projects/webkit/changeset/29412>.  I just updated and opened the WebKit solution as well as WebCore.vcproj just fine.  Make sure that those vcproj files don't have conflicts using "svn stat" as I've run into that XML error a few times due to conflicts in the file.

Comment 2 Matt Lilek 2008-01-15 17:36:20 PST

Setting the $WebKitLibrariesDir environment variable allows this to load.  Also, I get the XML parsing error for all the projects within the WebKit solution, not just WebCore and QTMovieWin.

Comment 3 Eric Seidel (no email) 2008-01-23 16:12:52 PST

We should at least document this on the instructions for building windows @ webkit.org

Comment 4 Eric Seidel (no email) 2008-01-23 16:14:15 PST

I guess this is documented at:
http://trac.webkit.org/projects/webkit/wiki/BuildingOnWindows

Comment 5 Alexey Proskuryakov 2008-01-23 23:50:55 PST

I think it's good that the project refuses to open - having mysterious build failures later would be much worse! Actually, I had this variable set incorrectly at first, and figuring that out wasn't quite trivial.

Comment 6 Brent Fulgham 2008-03-07 09:45:30 PST

Since this is now documented on the Wiki, and is part of the general knowledge base, I am closing this issue.