Bug 168868

Summary: A Locked indicator should be visually distinct from an unlocked indicator
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cdumez, commit-queue, joepeck, kling, koivisto, krollin, rniwa, slewis
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the feature
none
Archive of layout-test-results from ews115 for mac-elcapitan none

Ryosuke Niwa
Reported 2017-02-25 00:30:24 PST
A locked indicator on perf dashboard should look different from an unlocked indicator so that the user can tell whether he/she needs to unlock or not.
Attachments
Adds the feature (33.54 KB, patch)
2017-02-25 00:42 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-elcapitan (1.90 MB, application/zip)
2017-02-25 01:36 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-25 00:31:06 PST
<rdar://problem/29666054>
Ryosuke Niwa
Comment 2 2017-02-25 00:42:12 PST
Created attachment 302752 [details] Adds the feature
Build Bot
Comment 3 2017-02-25 01:36:43 PST
Comment on attachment 302752 [details] Adds the feature Attachment 302752 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3190227 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html
Build Bot
Comment 4 2017-02-25 01:36:47 PST
Created attachment 302754 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Ryosuke Niwa
Comment 5 2017-02-26 17:12:42 PST
EWS failures are most certainly not related to my perf dashboard changes.
WebKit Commit Bot
Comment 6 2017-02-27 01:47:01 PST
Comment on attachment 302752 [details] Adds the feature Clearing flags on attachment: 302752 Committed r213041: <http://trac.webkit.org/changeset/213041>
WebKit Commit Bot
Comment 7 2017-02-27 01:47:06 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.