Bug 168854 – Web Inspector: RTL: add support for Bezier/Spring editor

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Created attachment 302704 [details]
[Image] Screenshot of Issue

.

[Devin Rousso]

Created attachment 302710 [details]
Patch

[Devin Rousso]

Created attachment 302711 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 302710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302710&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:36
> +    --bezier-editor-preview-translateX: -170px;

Please split this into a base variable then derive the ltr and rtl ones as calc(-1 * var(--bezier-editor-preview-offset-start)) for RTL or 1 for LTR.

> Source/WebInspectorUI/UserInterface/Views/BezierEditor.css:141
> +    padding-left: 1px;

Use a variable.

> Source/WebInspectorUI/UserInterface/Views/SpringEditor.css:73
> +    left: 0;

Use a variable.

> Source/WebInspectorUI/UserInterface/Views/SpringEditor.css:110
> +    text-align: right;

This is unnecessary. Use value 'end' and you can remove the dir-dependent rule split.

> Source/WebInspectorUI/UserInterface/Views/SpringEditor.js:227
> +            this._previewElement.style.transform = "translateX(-85px)";

Why can't we use the 170px base variable from above?

[Devin Rousso]

Comment on attachment 302710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302710&action=review

>> Source/WebInspectorUI/UserInterface/Views/SpringEditor.js:227
>> +            this._previewElement.style.transform = "translateX(-85px)";
> 
> Why can't we use the 170px base variable from above?

The animation for the preview stops halfway across the available space to give room for the "spring" to show its effect.  If it went all the way across the preview area, then the "spring" wouldn't be visible.

[Devin Rousso]

Created attachment 302746 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 302746 [details]
Patch

Clearing flags on attachment: 302746

Committed r213002: <http://trac.webkit.org/changeset/213002>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.