Bug 168853

Summary:

Web Inspector: RTL: add support for Color Picker

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] Screenshot of Issue	none
Patch	bburg: review+
[Image] After Patch is applied	none
Patch	commit-queue: commit-queue-
Patch	none

Devin Rousso

Reported 2017-02-24 16:12:25 PST

Created attachment 302701 [details] [Image] Screenshot of Issue .

Attachments
[Image] Screenshot of Issue (37.70 KB, image/png) 2017-02-24 16:12 PST, Devin Rousso	no flags	Details
Patch (4.48 KB, patch) 2017-02-24 16:31 PST, Devin Rousso	bburg: review+	Details Formatted Diff Diff
[Image] After Patch is applied (46.27 KB, image/png) 2017-02-24 16:33 PST, Devin Rousso	no flags	Details
Patch (4.19 KB, patch) 2017-02-24 23:41 PST, Devin Rousso	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch (4.26 KB, patch) 2017-02-25 00:22 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2017-02-24 16:31:12 PST

Created attachment 302705 [details] Patch

Devin Rousso

Comment 2 2017-02-24 16:33:17 PST

Created attachment 302706 [details] [Image] After Patch is applied

Blaze Burg

Comment 3 2017-02-24 22:07:55 PST

Comment on attachment 302705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302705&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ColorPicker.css:60 > + left: calc(var(--color-picker-width) - var(--color-picker-brightness-start)); NIt: these need to say 'offset-start' if using with left/right.

Devin Rousso

Comment 4 2017-02-24 23:41:03 PST

Created attachment 302744 [details] Patch

WebKit Commit Bot

Comment 5 2017-02-25 00:20:38 PST

Comment on attachment 302744 [details] Patch Rejecting attachment 302744 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 302744, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 4029f7a..4cdba8a master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 212998 = 56ba9f16e2fb3dfb8e69e115c55048e156eb3894 r212999 = 4cdba8a45583e2de769a67a7fdd47fda3bb63fcb Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3190054

Devin Rousso

Comment 6 2017-02-25 00:22:44 PST

Created attachment 302750 [details] Patch

WebKit Commit Bot

Comment 7 2017-02-25 01:25:16 PST

Comment on attachment 302750 [details] Patch Clearing flags on attachment: 302750 Committed r213004: <http://trac.webkit.org/changeset/213004>

WebKit Commit Bot

Comment 8 2017-02-25 01:25:20 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.