Bug 168850

Summary:

Activate some new webrtc tests

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, eric.carlson, ryanhaddad

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch	none
Disabling ios sim wk2	none
Disabling ios sim wk2	none
Patch	none

youenn fablet

Reported 2017-02-24 16:08:38 PST

Activate some new webrtc tests on debug bots

Attachments
Patch (7.15 KB, patch) 2017-02-24 16:12 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-elcapitan (2.19 MB, application/zip) 2017-02-24 17:53 PST, Build Bot	no flags	Details
Patch (8.39 KB, patch) 2017-03-01 17:22 PST, youenn fablet	no flags	Details Formatted Diff Diff
Disabling ios sim wk2 (1.39 KB, patch) 2017-03-02 09:57 PST, youenn fablet	no flags	Details Formatted Diff Diff
Disabling ios sim wk2 (1.37 KB, patch) 2017-03-02 09:58 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.00 KB, patch) 2017-03-02 14:17 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-02-24 16:12:01 PST

Created attachment 302700 [details] Patch

youenn fablet

Comment 2 2017-02-24 16:12:35 PST

Need to investigate why the video.html test is failing. Rebasing it for now.

Build Bot

Comment 3 2017-02-24 17:53:24 PST

Comment on attachment 302700 [details] Patch Attachment 302700 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3187977 New failing tests: webrtc/libwebrtc/release-while-creating-offer.html webrtc/no-port-zero-in-upd-candidates.html webrtc/video.html webrtc/video-disabled-black.html webrtc/libwebrtc/release-while-getting-stats.html webrtc/libwebrtc/release-while-setting-local-description.html webrtc/datachannel/basic.html webrtc/rtcpeerconnection-error-messages.html webrtc/negotiatedneeded-event-addStream.html

Build Bot

Comment 4 2017-02-24 17:53:57 PST

Created attachment 302719 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

youenn fablet

Comment 5 2017-03-01 17:22:15 PST

Created attachment 303146 [details] Patch

WebKit Commit Bot

Comment 6 2017-03-02 08:04:49 PST

Comment on attachment 303146 [details] Patch Clearing flags on attachment: 303146 Committed r213282: <http://trac.webkit.org/changeset/213282>

WebKit Commit Bot

Comment 7 2017-03-02 08:04:53 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 8 2017-03-02 09:49:41 PST

It appears that the tests are failing on ios-simulator: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r213282%20(3918)/results.html

youenn fablet

Comment 9 2017-03-02 09:57:37 PST

Reopening to attach new patch.

youenn fablet

Comment 10 2017-03-02 09:57:38 PST

Created attachment 303212 [details] Disabling ios sim wk2

youenn fablet

Comment 11 2017-03-02 09:58:19 PST

Created attachment 303213 [details] Disabling ios sim wk2

WebKit Commit Bot

Comment 12 2017-03-02 10:13:51 PST

Comment on attachment 303213 [details] Disabling ios sim wk2 Clearing flags on attachment: 303213 Committed r213286: <http://trac.webkit.org/changeset/213286>

WebKit Commit Bot

Comment 13 2017-03-02 10:13:56 PST

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 14 2017-03-02 12:09:36 PST

It also looks like these are timing out on macOS Debug WK2: webrtc/audio-peer-connection-webaudio.html webrtc/datachannel/basic.html webrtc/datachannel/filter-ice-candidate.html webrtc/no-port-zero-in-upd-candidates.html https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r213285%20(11376)/results.html

youenn fablet

Comment 15 2017-03-02 13:27:18 PST

Probably related to disabling peer connection flag

youenn fablet

Comment 16 2017-03-02 13:29:08 PST

Let's reopen it to fix those mac wk2 debug tests

youenn fablet

Comment 17 2017-03-02 14:17:02 PST

Created attachment 303238 [details] Patch

WebKit Commit Bot

Comment 18 2017-03-02 15:38:36 PST

Comment on attachment 303238 [details] Patch Clearing flags on attachment: 303238 Committed r213310: <http://trac.webkit.org/changeset/213310>

WebKit Commit Bot

Comment 19 2017-03-02 15:38:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.