Bug 168843

Summary:

Windows build doesn't start build if the git branch is not master

Product:

WebKit

Reporter:

Basuke Suzuki <basuke>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

basuke, bfulgham, commit-queue, lforschler, pvollan

Priority:

Version:

WebKit Nightly Build

Hardware:

OS:

Windows 10

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews116 for mac-elcapitan	none

Basuke Suzuki

Reported 2017-02-24 14:03:14 PST

If using git on Windows and the branch is not master, build-webkit succeed to cmake build, but fail to start building by msbuild after that (or start building wrong solution). On git master, product dir is WebKitBuild/$(configuration)/, but if on some branch, it is WebKitBuild/$(git_branch_name)/$(configuration)/.

Attachments
Patch (1.24 KB, patch) 2017-02-24 14:12 PST, Basuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.94 MB, application/zip) 2017-02-24 18:29 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Basuke Suzuki

Comment 1 2017-02-24 14:12:38 PST

Created attachment 302687 [details] Patch Use correct value for product base dir.

Build Bot

Comment 2 2017-02-24 18:29:03 PST

Comment on attachment 302687 [details] Patch Attachment 302687 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3188347 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html

Build Bot

Comment 3 2017-02-24 18:29:35 PST

Created attachment 302723 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

WebKit Commit Bot

Comment 4 2017-02-28 12:38:36 PST

Comment on attachment 302687 [details] Patch Clearing flags on attachment: 302687 Committed r213162: <http://trac.webkit.org/changeset/213162>

WebKit Commit Bot

Comment 5 2017-02-28 12:38:40 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.