Circular Dependency between PluginPackageWin and PluginDatabaseWin

• Component: Plug-ins
• Status: RESOLVED FIXED

[Rodney Dawes]

There is a circular dependency between these too classes. The attached patch removes this dependency by moving the isPluginBlacklisted class method to a static internal method in PluginPackageWin.cpp, as the method does not appear to require any other parts of the PluginDatabaseWin code.

[Rodney Dawes]

Created attachment 18460 [details]
Patch to remove circular dependency

[Jon Honeycutt]

(In reply to comment #1)
> Created an attachment (id=18460) [edit]
> Patch to remove circular dependency
> 
Looks good, but I think you could make isPluginBlacklisted a private member method of PluginPackageWin. Then you could remove the getFileVersion method, as this is its only caller.

[Rodney Dawes]

Created attachment 18462 [details]
Updated patch to clean up as per comments

[Jon Honeycutt]

Comment on attachment 18462 [details]
Updated patch to clean up as per comments

I think your ChangeLog entry could use some punctuation. I think you could also put the Silverlight version constants inside the function body. Otherwise looks great. Thanks for working on this!

r=me

[Rodney Dawes]

Created attachment 18472 [details]
Updated patch to move constants into fuction and add punctuation to ChangeLog

[Jon Honeycutt]

Comment on attachment 18472 [details]
Updated patch to move constants into fuction and add punctuation to ChangeLog

Submitted in r29532. Thanks!