Bug 168812 – REGRESSION(r212542): Make TimeSeriesChart.computeTimeGrid stops x-axis grid prematurely

• Component: Perf Dashboard
• Status: RESOLVED FIXED

[Ryosuke Niwa]

When the time range is too big compared to the available width,
we don't stop drawing the x-axis grid before reaching the end.

This is a regression from https://trac.webkit.org/changeset/212542

[Ryosuke Niwa]

Created attachment 302620 [details]
Fixes the bug

[WebKit Commit Bot]

Attachment 302620 [details] did not pass style-queue:


ERROR: Source/WebCore/html/HTMLSlotElement.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/dom/Document.cpp:206:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/dom/Document.cpp:209:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/dom/ContainerNode.cpp:142:  Missing spaces around ||  [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:552:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:555:  Missing spaces around ||  [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:556:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:567:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:622:  Missing spaces around ||  [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:685:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:688:  Missing spaces around ||  [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:689:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:742:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/dom/ContainerNode.cpp:742:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:748:  Missing spaces around ||  [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:749:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/dom/ContainerNode.cpp:749:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/Document.h:1293:  Missing spaces around ||  [whitespace/operators] [3]
Total errors found: 18 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Created attachment 302621 [details]
Removed superfluous changes

[Joseph Pecoraro]

Comment on attachment 302621 [details]
Removed superfluous changes

View in context: https://bugs.webkit.org/attachment.cgi?id=302621&action=review

rs=me

> Websites/perf.webkit.org/public/v3/components/time-series-chart.js:713
>                  diff: 31 * DAY,

So this is 31 but the others are multiples of 30?

[Ryosuke Niwa]

(In reply to comment #4)
> Comment on attachment 302621 [details]
> Removed superfluous changes
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302621&action=review
> 
> rs=me
> 
> > Websites/perf.webkit.org/public/v3/components/time-series-chart.js:713
> >                  diff: 31 * DAY,
> 
> So this is 31 but the others are multiples of 30?

Yeah, we can change it to 30 but I kept it this way for now.

[WebKit Commit Bot]

Comment on attachment 302621 [details]
Removed superfluous changes

Clearing flags on attachment: 302621

Committed r212935: <http://trac.webkit.org/changeset/212935>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.