Summary: | REGRESSION(r212542): Make TimeSeriesChart.computeTimeGrid stops x-axis grid prematurely | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Perf Dashboard | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dbates, dewei_zhu, esprehn+autocc, gyuyoung.kim, joepeck, kangil.han, kling, koivisto, rniwa, slewis | ||||||
Priority: | P2 | ||||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 168499 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-02-23 18:03:51 PST
Created attachment 302620 [details]
Fixes the bug
Attachment 302620 [details] did not pass style-queue:
ERROR: Source/WebCore/html/HTMLSlotElement.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/dom/Document.cpp:206: Bad include order. Mixing system and custom headers. [build/include_order] [4]
ERROR: Source/WebCore/dom/Document.cpp:209: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/dom/ContainerNode.cpp:142: Missing spaces around || [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:552: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:555: Missing spaces around || [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:556: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:567: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:622: Missing spaces around || [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:685: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:688: Missing spaces around || [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:689: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:742: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/dom/ContainerNode.cpp:742: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:748: Missing spaces around || [whitespace/operators] [3]
ERROR: Source/WebCore/dom/ContainerNode.cpp:749: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/dom/ContainerNode.cpp:749: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/dom/Document.h:1293: Missing spaces around || [whitespace/operators] [3]
Total errors found: 18 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 302621 [details]
Removed superfluous changes
Comment on attachment 302621 [details] Removed superfluous changes View in context: https://bugs.webkit.org/attachment.cgi?id=302621&action=review rs=me > Websites/perf.webkit.org/public/v3/components/time-series-chart.js:713 > diff: 31 * DAY, So this is 31 but the others are multiples of 30? (In reply to comment #4) > Comment on attachment 302621 [details] > Removed superfluous changes > > View in context: > https://bugs.webkit.org/attachment.cgi?id=302621&action=review > > rs=me > > > Websites/perf.webkit.org/public/v3/components/time-series-chart.js:713 > > diff: 31 * DAY, > > So this is 31 but the others are multiples of 30? Yeah, we can change it to 30 but I kept it this way for now. Comment on attachment 302621 [details] Removed superfluous changes Clearing flags on attachment: 302621 Committed r212935: <http://trac.webkit.org/changeset/212935> All reviewed patches have been landed. Closing bug. |