Bug 168804

Summary: [CredentialManagement] CredentialManagement API should be on top of SecureContext
Product: WebKit Reporter: Jiewen Tan <jiewen_tan>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ajuma, bfulgham, buildbot, cdumez, danyao, dbates, esprehn+autocc, jiewen_tan, kondapallykalyan, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 158121    
Bug Blocks: 167375    
Attachments:
Description Flags
Add SecureContext to IDL sam: review-

Jiewen Tan
Reported 2017-02-23 15:03:25 PST
CredentialManagement API should be on top of SecureContext according to the spec: https://w3c.github.io/webappsec-credential-management/#interfaces
Attachments
Add SecureContext to IDL (1.97 KB, patch)
2017-05-12 00:50 PDT, Danyao Wang 		sam: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-23 15:04:28 PST
<rdar://problem/30684315>
Danyao Wang
Comment 2 2017-05-12 00:50:23 PDT
Created attachment 309881 [details] Add SecureContext to IDL
Daniel Bates
Comment 3 2017-05-12 05:31:49 PDT
Comment on attachment 309881 [details] Add SecureContext to IDL For consistency we should also update the IDL embedded in the existing test <https://trac.webkit.org/browser/webkit/trunk/LayoutTests/credentials/idlharness.html>.
Danyao Wang
Comment 4 2017-05-12 08:00:25 PDT
It looks like SecureContext is already added to all interfaces in idlharness.html: https://trac.webkit.org/browser/webkit/trunk/LayoutTests/credentials/idlharness.html#L50 Am I missing something?
Sam Weinig
Comment 5 2017-05-12 12:37:49 PDT
Comment on attachment 309881 [details] Add SecureContext to IDL I don't think this does anything, as we don't support the SecureContext attribute yet.
Jiewen Tan
Comment 6 2018-01-22 13:19:40 PST
Fixed by changes in Bug 181082.
Note You need to log in before you can comment on or make changes to this bug.