Bug 168781

Summary:

[Readable Streams API] Implement ReadableStreamBYOBRequest respond() (closed stream state)

Product:

WebKit

Reporter:

Romain Bellessort <romain.wkt>

Component:

WebCore Misc.

Assignee:

Romain Bellessort <romain.wkt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, calvaris, commit-queue, rniwa, youennf

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none

Romain Bellessort

Reported 2017-02-23 08:45:21 PST

Implement respond() method of ReadableStreamBYOBRequest. As this method covers multiple cases, this bug focuses on the case where the stream is in closed state.

Attachments
Patch (17.60 KB, patch) 2017-03-07 09:48 PST, Romain Bellessort	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.74 MB, application/zip) 2017-03-07 11:18 PST, Build Bot	no flags	Details
Patch (17.60 KB, patch) 2017-03-08 01:01 PST, Romain Bellessort	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.76 MB, application/zip) 2017-03-08 09:19 PST, Build Bot	no flags	Details
Patch (17.60 KB, patch) 2017-03-08 09:35 PST, Romain Bellessort	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (785.32 KB, application/zip) 2017-03-08 10:50 PST, Build Bot	no flags	Details
Patch (17.34 KB, patch) 2017-03-09 05:50 PST, Romain Bellessort	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Romain Bellessort

Comment 1 2017-03-07 09:48:28 PST

Created attachment 303667 [details] Patch

Build Bot

Comment 2 2017-03-07 11:18:08 PST

Comment on attachment 303667 [details] Patch Attachment 303667 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3260028 New failing tests: imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html streams/readable-stream-byob-request.html imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker.html

Build Bot

Comment 3 2017-03-07 11:18:12 PST

Created attachment 303683 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Romain Bellessort

Comment 4 2017-03-08 01:01:29 PST

Created attachment 303790 [details] Patch

Build Bot

Comment 5 2017-03-08 09:19:11 PST

Comment on attachment 303790 [details] Patch Attachment 303790 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3266094 New failing tests: imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html streams/readable-stream-byob-request.html imported/w3c/web-platform-tests/streams/readable-byte-streams/general.dedicatedworker.html

Build Bot

Comment 6 2017-03-08 09:19:14 PST

Created attachment 303815 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Romain Bellessort

Comment 7 2017-03-08 09:35:02 PST

Created attachment 303816 [details] Patch

Build Bot

Comment 8 2017-03-08 10:50:54 PST

Comment on attachment 303816 [details] Patch Attachment 303816 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3266931 New failing tests: media/track/media-element-enqueue-event-crash.html

Build Bot

Comment 9 2017-03-08 10:50:58 PST

Created attachment 303821 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Romain Bellessort

Comment 10 2017-03-09 05:50:27 PST

Created attachment 303911 [details] Patch

WebKit Commit Bot

Comment 11 2017-03-12 10:27:51 PDT

Comment on attachment 303911 [details] Patch Clearing flags on attachment: 303911 Committed r213770: <http://trac.webkit.org/changeset/213770>

WebKit Commit Bot

Comment 12 2017-03-12 10:27:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.