Bug 168765

Summary:

Move instance members from WebPDFView to implementation file

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, juergen, mitz, thorton

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Archive of layout-test-results from ews113 for mac-elcapitan	none

Aakash Jain

Reported 2017-02-22 21:19:23 PST

The instance members from WebPDFView are not exported. However they are exposed in header file. We should move them to implementation file. Note that this class is iOS specific.

Attachments
Proposed patch (1.88 KB, patch) 2017-02-22 21:25 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.67 MB, application/zip) 2017-02-22 22:41 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-22 21:25:34 PST

Created attachment 302490 [details] Proposed patch

Build Bot

Comment 2 2017-02-22 22:41:12 PST

Comment on attachment 302490 [details] Proposed patch Attachment 302490 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3176931 New failing tests: fast/dom/timer-throttling-hidden-page-non-nested.html

Build Bot

Comment 3 2017-02-22 22:41:15 PST

Created attachment 302495 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

WebKit Commit Bot

Comment 4 2017-02-22 23:26:10 PST

Comment on attachment 302490 [details] Proposed patch Clearing flags on attachment: 302490 Committed r212880: <http://trac.webkit.org/changeset/212880>

WebKit Commit Bot

Comment 5 2017-02-22 23:26:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.