| Summary: | Web Inspector: Elements tab: show indicators for hidden DOM breakpoints | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, timothy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 168101 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
Looks awesome! Few comments: - Are these indicators going to be clickable, similar to breakpoints in the gutter in the Resources tab? - We currently have an indicator for CSS pseudo-classes, so how would that interplay with that? - Lastly, what do you want to do in the case that the user wants to put a breakpoint on the <html> tag? (In reply to comment #1) > Looks awesome! Few comments: > - Are these indicators going to be clickable, similar to breakpoints in the > gutter in the Resources tab? DOM breakpoint indicators have content menu support only for now (https://webkit.org/b/168101). In the future it could be useful to support single-clicking to toggle the disabled state. > - We currently have an indicator for CSS pseudo-classes, so how would that > interplay with that? There shouldn't be any conflict, for the reason below. Will confirm this. > - Lastly, what do you want to do in the case that the user wants to put a > breakpoint on the <html> tag? The attached mockup is a little misleading. In practice, the DOM tree content view makes room for the gutter when the first breakpoint is added. There is no overlap with disclosure triangles. It probably makes sense to disallow editing of subtree breakpoints from the "hollow" breakpoint marker's context menu. A "Reveal Breakpoint" command that revealed the first descendant with a DOM breakpoint would be nice though. Created attachment 305446 [details]
Patch
Created attachment 305447 [details]
[Video] w/ patch applied
Comment on attachment 305446 [details]
Patch
This looks great! Nice job.
Comment on attachment 305446 [details] Patch Clearing flags on attachment: 305446 Committed r214844: <http://trac.webkit.org/changeset/214844> All reviewed patches have been landed. Closing bug. |
Created attachment 302484 [details] [Image] DOM breakpoint gutter enhancements Summary: Show indicators for hidden DOM breakpoints. Proposal: Show a hollow breakpoint indicator on collapsed DOM tree elements, when one or more child elements has a breakpoint. See attached mockup.