Reproducible assertion failure in SQLTransaction::performNextStep()

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

Steps to reproduce:
1. Open <http://webkit.org/misc/DatabaseExample.html>
2. Start opening and closing notes.

Pretty soon, an assertion fails:
ASSERTION FAILED: m_nextStep == &SQLTransaction::openTransactionAndPreflight || m_nextStep == &SQLTransaction::runStatements || m_nextStep == &SQLTransaction::postflightAndCommit || m_nextStep == &SQLTransaction::cleanupAfterTransactionErrorCallback
(/Users/ap/Safari/OpenSource/WebCore/storage/SQLTransaction.cpp:95 bool WebCore::SQLTransaction::performNextStep())

[Alexey Proskuryakov]

It's worth noting that the assertion fails when closing a note. I've just got a failure after the very first attempt to close a note, without opening any:

[Session started at 2008-01-15 12:36:42 +0300.]
Iteration of main loop for DatabaseThread 0x19377970
Performing DatabaseTask 0x14df39b0
Opening and preflighting transaction 0x14de2260
SQL - prepare - PRAGMA max_page_count = 5120
SQL - step - PRAGMA max_page_count = 5120
SQL - finalize - PRAGMA max_page_count = 5120
SQL - prepare - BEGIN;
SQL - step - BEGIN;
SQL - finalize - BEGIN;
Performing DatabaseTask 0x14de5680
ASSERTION FAILED: m_nextStep == &SQLTransaction::openTransactionAndPreflight || m_nextStep == &SQLTransaction::runStatements || m_nextStep == &SQLTransaction::postflightAndCommit || m_nextStep == &SQLTransaction::cleanupAfterTransactionErrorCallback
(/Users/ap/Safari/OpenSource/WebCore/storage/SQLTransaction.cpp:95 bool WebCore::SQLTransaction::performNextStep())

[Alexey Proskuryakov]

(gdb) p m_currentTransaction->m_ptr->m_nextStep
$3 = {
  __pfn = 0x203777e <WebCore::SQLTransaction::deliverTransactionCallback()>, 
  __delta = 0
}

[Alexey Proskuryakov]

Created attachment 18455 [details]
test case (assertion failure)

With the test, I'm seeing a different next step, but the underlying problem is probably the same.

(gdb) p m_currentTransaction->m_ptr->m_nextStep
$2 = {
  __pfn = 0x2038250 <WebCore::SQLTransaction::runStatements()>, 
  __delta = 0
}

[Mark Rowe (bdash)]

<rdar://problem/5688428>

[Timothy Hatcher]

Landed a fix in r29872 and r29876.

[Alexey Proskuryakov]

This test still results in an assertion failure for me, filed bug 17140.