Bug 168745

Summary: Add GTK+ build instruction to ReadMe.md
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Did more cleanup mcatanzaro: review+, mcatanzaro: commit-queue-

Ryosuke Niwa
Reported 2017-02-22 14:40:02 PST
Add instructions now that I know you just need to run two commands.
Attachments
Patch (2.44 KB, patch)
2017-02-22 14:42 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Did more cleanup (2.66 KB, patch)
2017-02-22 14:45 PST, Ryosuke Niwa 		mcatanzaro: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-22 14:42:20 PST
Created attachment 302445 [details] Patch
Ryosuke Niwa
Comment 2 2017-02-22 14:45:18 PST
Created attachment 302446 [details] Did more cleanup
Michael Catanzaro
Comment 3 2017-02-22 19:28:39 PST
Comment on attachment 302446 [details] Did more cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=302446&action=review > ReadMe.md:90 > +*Note*: To build and run GTK+ port, you need a Git checkout, not a Subversion checkout. Well I assume SVN would work just as well; there's nothing port-specific about it. So I would just remove this sentence. I guess our BuildingGtk page doesn't mention SVN because we figure there's no way anybody outside Apple would ever want to use SVN when git is available. We really, really don't understand why you still use it. :P > ReadMe.md:97 > +Then run the following command to build those dependencies: "those" -> "additional" > ReadMe.md:108 > +For more information, see the [wiki page](https://trac.webkit.org/wiki/BuildingGtk). I would add one sentence here: "Note that the procedure for building release tarballs is different. For more information..."
Ryosuke Niwa
Comment 4 2017-02-22 20:45:33 PST
Committed r212875: <http://trac.webkit.org/changeset/212875>
Note You need to log in before you can comment on or make changes to this bug.