Summary: | Web Inspector: RTL: add FindBanner support for RTL layout | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||||||||
Component: | Web Inspector | Assignee: | BJ Burg <bburg> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bburg, inspector-bugzilla-changes, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Attachments: |
|
Created attachment 302395 [details]
Console Find Banner (LTR)
Created attachment 302396 [details]
Console Find Banner (RTL)
Created attachment 302397 [details]
Resources Tab Find Banner (LTR)
Created attachment 302398 [details]
Resources Tab Find Banner (RTL)
To Test: - Cmd-F in {console, resource} tab => should pop up the find banner with correct layout => Clicking on each button should NOT change styling => Can enter search text into field => Search results label is positioned correctly => Border styles look right when window is active or inactive Created attachment 302399 [details]
Patch
*** Bug 168279 has been marked as a duplicate of this bug. *** Comment on attachment 302399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302399&action=review > Source/WebInspectorUI/UserInterface/Views/FindBanner.css:100 > + --find-banner-search-box-border-radius-end: 0; I think you could simplify this by just having a single `border-radius: 0;` in this rule and then only setting the ones that are needed with `--find-banner-search-box-border-radius-start`. > Source/WebInspectorUI/UserInterface/Views/FindBanner.css:265 > + --console-find-banner-search-box-border-radius-end: 0; Ditto. Comment on attachment 302399 [details]
Patch
Should the whole content of the bar be right aligned in RTL too?
Committed r214048: <http://trac.webkit.org/changeset/214048> |
Created attachment 302394 [details] SCREENSHOT - ToT (RTL) It's messed up.