Bug 168723

Summary:

Web Inspector: RTL: add FindBanner support for RTL layout

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
SCREENSHOT - ToT (RTL)	none
Console Find Banner (LTR)	none
Console Find Banner (RTL)	none
Resources Tab Find Banner (LTR)	none
Resources Tab Find Banner (RTL)	none
Patch	timothy: review+

Blaze Burg

Reported 2017-02-22 06:36:15 PST

Created attachment 302394 [details] SCREENSHOT - ToT (RTL) It's messed up.

Attachments
SCREENSHOT - ToT (RTL) (35.02 KB, image/png) 2017-02-22 06:36 PST, Blaze Burg	no flags	Details
Console Find Banner (LTR) (31.84 KB, image/png) 2017-02-22 06:37 PST, Blaze Burg	no flags	Details
Console Find Banner (RTL) (32.38 KB, image/png) 2017-02-22 06:37 PST, Blaze Burg	no flags	Details
Resources Tab Find Banner (LTR) (56.77 KB, image/png) 2017-02-22 06:38 PST, Blaze Burg	no flags	Details
Resources Tab Find Banner (RTL) (141.83 KB, image/png) 2017-02-22 06:38 PST, Blaze Burg	no flags	Details
Patch (15.81 KB, patch) 2017-02-22 07:11 PST, Blaze Burg	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2017-02-22 06:37:02 PST

Created attachment 302395 [details] Console Find Banner (LTR)

Blaze Burg

Comment 2 2017-02-22 06:37:27 PST

Created attachment 302396 [details] Console Find Banner (RTL)

Blaze Burg

Comment 3 2017-02-22 06:38:26 PST

Created attachment 302397 [details] Resources Tab Find Banner (LTR)

Blaze Burg

Comment 4 2017-02-22 06:38:45 PST

Created attachment 302398 [details] Resources Tab Find Banner (RTL)

Blaze Burg

Comment 5 2017-02-22 06:41:01 PST

To Test: - Cmd-F in {console, resource} tab => should pop up the find banner with correct layout => Clicking on each button should NOT change styling => Can enter search text into field => Search results label is positioned correctly => Border styles look right when window is active or inactive

Blaze Burg

Comment 6 2017-02-22 07:11:49 PST

Created attachment 302399 [details] Patch

Blaze Burg

Comment 7 2017-02-22 13:04:33 PST

<rdar://problem/30507071>

Blaze Burg

Comment 8 2017-02-22 13:04:44 PST

*** Bug 168279 has been marked as a duplicate of this bug. ***

Devin Rousso

Comment 9 2017-02-23 15:44:07 PST

Comment on attachment 302399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302399&action=review > Source/WebInspectorUI/UserInterface/Views/FindBanner.css:100 > + --find-banner-search-box-border-radius-end: 0; I think you could simplify this by just having a single `border-radius: 0;` in this rule and then only setting the ones that are needed with `--find-banner-search-box-border-radius-start`. > Source/WebInspectorUI/UserInterface/Views/FindBanner.css:265 > + --console-find-banner-search-box-border-radius-end: 0; Ditto.

Timothy Hatcher

Comment 10 2017-03-09 09:14:15 PST

Comment on attachment 302399 [details] Patch Should the whole content of the bar be right aligned in RTL too?

Blaze Burg

Comment 11 2017-03-16 10:20:00 PDT

Committed r214048: <http://trac.webkit.org/changeset/214048>

Note You need to log in before you can comment on or make changes to this bug.