Bug 168714

Summary: [GTK] [2.15.90] Disable RESOURCE_USAGE on non-Linux systems
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, buildbot, commit-queue, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan none

Description Alberto Garcia 2017-02-22 02:47:21 PST 
ENABLE_RESOURCE_USAGE is set to ON by default in WebKitGTK+, but it only works on Linux. The build fails in other systems because of that:

../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/page/ResourceUsageThread.cpp.o: In function `WebCore::ResourceUsageThread::threadBody()':
./Source/WebCore/page/ResourceUsageThread.cpp:120: undefined reference to `WebCore::ResourceUsageThread::platformThreadBody(JSC::VM*, WebCore::ResourceUsageData&)'
collect2: error: ld returned 1 exit status
Comment 1 Alberto Garcia 2017-02-22 02:48:55 PST 
Created attachment 302379 [details]
Patch
Comment 2 Build Bot 2017-02-22 04:45:07 PST 
Comment on attachment 302379 [details]
Patch

Attachment 302379 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3172113

New failing tests:
editing/spelling/spellcheck-async.html
Comment 3 Build Bot 2017-02-22 04:45:10 PST 
Created attachment 302387 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 WebKit Commit Bot 2017-02-22 08:55:03 PST 
Comment on attachment 302379 [details]
Patch

Clearing flags on attachment: 302379

Committed r212829: <http://trac.webkit.org/changeset/212829>
Comment 5 WebKit Commit Bot 2017-02-22 08:55:09 PST 
All reviewed patches have been landed.  Closing bug.