Bug 168714

Summary: [GTK] [2.15.90] Disable RESOURCE_USAGE on non-Linux systems
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, buildbot, commit-queue, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews103 for mac-elcapitan none

Alberto Garcia
Reported 2017-02-22 02:47:21 PST
ENABLE_RESOURCE_USAGE is set to ON by default in WebKitGTK+, but it only works on Linux. The build fails in other systems because of that: ../../lib/../Source/WebCore/CMakeFiles/WebCore.dir/page/ResourceUsageThread.cpp.o: In function `WebCore::ResourceUsageThread::threadBody()': ./Source/WebCore/page/ResourceUsageThread.cpp:120: undefined reference to `WebCore::ResourceUsageThread::platformThreadBody(JSC::VM*, WebCore::ResourceUsageData&)' collect2: error: ld returned 1 exit status
Attachments
Patch (1.68 KB, patch)
2017-02-22 02:48 PST, Alberto Garcia 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (987.31 KB, application/zip)
2017-02-22 04:45 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2017-02-22 02:48:55 PST
Created attachment 302379 [details] Patch
Build Bot
Comment 2 2017-02-22 04:45:07 PST
Comment on attachment 302379 [details] Patch Attachment 302379 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3172113 New failing tests: editing/spelling/spellcheck-async.html
Build Bot
Comment 3 2017-02-22 04:45:10 PST
Created attachment 302387 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 4 2017-02-22 08:55:03 PST
Comment on attachment 302379 [details] Patch Clearing flags on attachment: 302379 Committed r212829: <http://trac.webkit.org/changeset/212829>
WebKit Commit Bot
Comment 5 2017-02-22 08:55:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.