Bug 168705

Summary: Move instance members from WebPDFViewPlaceholder.h to implementation file
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit Misc.Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen, mitz, thorton
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Updated patch
none
Updated patch none

Aakash Jain
Reported 2017-02-21 20:45:51 PST
There are few symbols in WebPDFViewPlaceholder interface in WebKit/ios/WebView/WebPDFViewPlaceholder.h and are not exported. We should export these symbols so that the headers matches with the library.
Attachments
Proposed patch (1.28 KB, patch)
2017-02-21 20:48 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (2.15 KB, patch)
2017-02-22 13:11 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (2.44 KB, patch)
2017-02-22 13:41 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-02-21 20:48:17 PST
Created attachment 302363 [details] Proposed patch
Aakash Jain
Comment 2 2017-02-22 13:11:18 PST
Created attachment 302428 [details] Updated patch Moving instance members to implementation file as this is a better approach instead of exposing symbols.
Juergen Ributzka
Comment 3 2017-02-22 13:23:46 PST
You can now also remove the {} braces after the @interface declaration. You added the ivars to a WebPDFViewPlaceholder category. That doesn't seem right. Shouldn't they be added to the @implementation?
Aakash Jain
Comment 4 2017-02-22 13:41:03 PST
Created attachment 302433 [details] Updated patch remove extra {} and added ivars to @implementation.
WebKit Commit Bot
Comment 5 2017-02-22 15:40:17 PST
Comment on attachment 302433 [details] Updated patch Clearing flags on attachment: 302433 Committed r212858: <http://trac.webkit.org/changeset/212858>
WebKit Commit Bot
Comment 6 2017-02-22 15:40:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.