Bug 168674

Summary:

Export symbols for various classes present in webkit SPI

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, juergen, mitz

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=168726

Attachments:

Description	Flags
Proposed patch	none

Aakash Jain

Reported 2017-02-21 14:21:44 PST

Various interfaces in WebKit are present in private headers, however the corresponding symbols are not included in .exp file. We should export these symbols so that the headers matches with the library.

Attachments
Proposed patch (2.20 KB, patch) 2017-02-21 14:25 PST, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-21 14:25:27 PST

Created attachment 302306 [details] Proposed patch

WebKit Commit Bot

Comment 2 2017-02-21 15:18:28 PST

Comment on attachment 302306 [details] Proposed patch Clearing flags on attachment: 302306 Committed r212770: <http://trac.webkit.org/changeset/212770>

WebKit Commit Bot

Comment 3 2017-02-21 15:18:33 PST

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 4 2017-02-21 22:29:48 PST

Comment on attachment 302306 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=302306&action=review > Source/WebKit/mac/WebKit.exp:156 > +.objc_class_name_WKQuadObject WKQuadObject surprises me a lot. Both interface and implementation are iOS only, why didn't this patch break the build?

Aakash Jain

Comment 5 2017-02-22 08:50:14 PST

You are right. It is iOS specific. Good catch. It probably did not break the build, because ld considered it as a warning instead of error. Here is output when I did a local 32-bit mac build. ld: warning: ignoring undefined symbol .objc_class_name_WKQuadObject from -exported_symbols_list ld: warning: ignoring undefined symbol .objc_class_name_WebVisiblePosition from -exported_symbols_list ld: warning: ignoring undefined symbol .objc_class_name_WebFixedPositionContent from -exported_symbols_list ld: warning: ignoring undefined symbol .objc_class_name_WebGeolocation from -exported_symbols_list

Aakash Jain

Comment 6 2017-02-22 08:51:04 PST

fix in https://bugs.webkit.org/show_bug.cgi?id=168726

Note You need to log in before you can comment on or make changes to this bug.