Bug 168637

Summary: NetworkProcess: Stop disabling buffering when NETWORK_CACHE is disabled in build
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, koivisto, ossy, zan
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=137692
Attachments:
Description Flags
Patch achristensen: review+

Description Carlos Garcia Campos 2017-02-20 22:30:42 PST
It was added in r193752 as part of bug #137692 to fix an infinite loop in network process that happened in EFL because they didn't enable the network cache at that time. I think that was actually a workaround, and it was added without any comment so it has stayed there even when EFL enabled disk cache, and now that is gone. Looking at current code I see no reason why buffering can't work with the disk cache disabled, so I think it's time to remove that workaround.
Comment 1 Carlos Garcia Campos 2017-02-20 22:32:34 PST
Created attachment 302231 [details]
Patch
Comment 2 Csaba Osztrogon√°c 2017-02-20 22:53:14 PST
(In reply to comment #0)
> It was added in r193752 as part of bug #137692 to fix an infinite loop in
> network process that happened in EFL because they didn't enable the network
> cache at that time. I think that was actually a workaround, and it was added
> without any comment so it has stayed there even when EFL enabled disk cache,
> and now that is gone. Looking at current code I see no reason why buffering
> can't work with the disk cache disabled, so I think it's time to remove that
> workaround.

Have you tried it out with disabled network cache or do you just think that it will work?
Comment 3 Carlos Garcia Campos 2017-02-20 22:59:54 PST
(In reply to comment #2)
> (In reply to comment #0)
> > It was added in r193752 as part of bug #137692 to fix an infinite loop in
> > network process that happened in EFL because they didn't enable the network
> > cache at that time. I think that was actually a workaround, and it was added
> > without any comment so it has stayed there even when EFL enabled disk cache,
> > and now that is gone. Looking at current code I see no reason why buffering
> > can't work with the disk cache disabled, so I think it's time to remove that
> > workaround.
> 
> Have you tried it out with disabled network cache or do you just think that
> it will work?

Nope, I've just read the buffering code in the network process.
Comment 4 Carlos Garcia Campos 2017-02-22 00:35:36 PST
Committed r212816: <http://trac.webkit.org/changeset/212816>