Bug 168594 – [WebRTC][Mac] Network process sandbox does not allow WebRTC networking

• Component: WebKit2
• Status: RESOLVED FIXED

[youenn fablet]

Network process sandbox does not allow WebRTC networking

[youenn fablet]

Created attachment 302143 [details]
Patch

[Build Bot]

Comment on attachment 302143 [details]
Patch

Attachment 302143 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3159660

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 302147 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 302173 [details]
Patch

[youenn fablet]

(In reply to comment #3)
> Created attachment 302147 [details]
> Archive of layout-test-results from ews105 for mac-elcapitan-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-wk2-ews.
> Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

ElCapitain does not know about with-filter.
Inlining its definition into NetworkProcess sandbox should fix the issue.

[Brent Fulgham]

Comment on attachment 302173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302173&action=review

I misunderstood what you described to me in person -- this is absolutely a better approach than my first attempt. r=me.

> Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:212
> +(macro (with-filter form)

"with-filter" is now defined in the core Sandboxing language. I don't think you need to redefine this here.

> Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:247
> +(with-filter (extension "com.apple.webkit.webrtc")

Much better than my approach!

[youenn fablet]

Thanks for the review.

(In reply to comment #6)
> Comment on attachment 302173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=302173&action=review
> 
> I misunderstood what you described to me in person -- this is absolutely a
> better approach than my first attempt. r=me.
> 
> > Source/WebKit2/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:212
> > +(macro (with-filter form)
> 
> "with-filter" is now defined in the core Sandboxing language. I don't think
> you need to redefine this here.

I needed to add it for ElCapitan.

[youenn fablet]

Created attachment 302295 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 302295 [details]
Patch for landing

Clearing flags on attachment: 302295

Committed r212746: <http://trac.webkit.org/changeset/212746>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.