Bug 168537

Summary: [JSC] Fix missing header in AbstractMacroAssembler.h
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review-, buildbot: commit-queue-

Guillaume Emont
Reported 2017-02-17 15:27:54 PST
AbstractMacroAssembler.h should include wtf/Vector.h as it uses vectors. As of now, it relies on wtf/Vector.h being included by another header, which is why MacroAssemblerX86Common.h has to include X86Assembler.h before AbstractMacroAssembler.h, breaking our style rules. The same issue would arise for MIPS, and solving this bug would allow to provide a proper fix for #168402.
Attachments
Patch (2.31 KB, patch)
2017-02-17 15:59 PST, Guillaume Emont 		mark.lam: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2017-02-17 15:59:33 PST
Created attachment 302004 [details] Patch Patch adding the include and fixing include orders.
Build Bot
Comment 2 2017-02-18 02:59:57 PST
Comment on attachment 302004 [details] Patch Attachment 302004 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/3148592 New failing tests: stress/regress-159537.js.default
Mark Lam
Comment 3 2017-03-13 17:12:54 PDT
Comment on attachment 302004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=302004&action=review > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:31 > -#include "X86Assembler.h" > #include "AbstractMacroAssembler.h" > +#include "X86Assembler.h" This breaks the Mac (and iOS) builds (debug builds previously, and now release builds too after r213743).
Note You need to log in before you can comment on or make changes to this bug.