Bug 168536

Summary: Stop exporting interface WebCoreScrollView on iOS
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit Misc.Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, juergen, mitz
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch
ap: review-, ap: commit-queue-
Updated patch
none
Updated patch
none
Updated patch none

Description Aakash Jain 2017-02-17 15:21:24 PST 
WebCoreScrollView in WebKit/mac/WebView/WebHTMLView.mm is unused. This is unused for last 10 years.
Comment 1 Aakash Jain 2017-02-17 15:24:40 PST 
Created attachment 301999 [details]
Proposed patch
Comment 2 Aakash Jain 2017-02-17 15:53:57 PST 
Created attachment 302002 [details]
Proposed patch
Comment 3 mitz 2017-02-17 16:27:30 PST 
Comment on attachment 302002 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302002&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:-787
> -// <rdar://problem/4985524> References to WebCoreScrollView as a subview of a WebHTMLView may be present
> -// in some NIB files, so NSUnarchiver must be still able to look up this now-unused class.
> -@interface WebCoreScrollView : NSScrollView
> -@end
> -
> -@implementation WebCoreScrollView
> -@end

So we think that those references are only in nib files in apps that no longer need to be supported?
Comment 4 Alexey Proskuryakov 2017-02-17 17:19:04 PST 
Let's remove it on iOS only, and keep on Mac. Definitely no risk on iOS.
Comment 5 Aakash Jain 2017-02-20 15:38:54 PST 
Created attachment 302183 [details]
Updated patch

Export the symbol for WebCoreScrollView only for mac.
Comment 6 mitz 2017-02-20 15:55:54 PST 
Comment on attachment 302183 [details]
Updated patch

Can we also move the class definition into the #if !PLATFORM(IOS) section?
Comment 7 Aakash Jain 2017-02-20 16:01:15 PST 
Created attachment 302187 [details]
Updated patch

Moved the class definition into the #if !PLATFORM(IOS) section.
Comment 8 mitz 2017-02-20 17:07:09 PST 
Comment on attachment 302187 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302187&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:781
> +#if PLATFORM(IOS)

I think this was meant to be part of the #if !PLATFORM(IOS) section below. This is the opposite!
Comment 9 Aakash Jain 2017-02-20 17:16:18 PST 
Created attachment 302208 [details]
Updated patch

You are right. If condition got reverted somehow. Fixed it now.
Comment 10 WebKit Commit Bot 2017-02-20 20:46:02 PST 
Comment on attachment 302208 [details]
Updated patch

Clearing flags on attachment: 302208

Committed r212697: <http://trac.webkit.org/changeset/212697>
Comment 11 WebKit Commit Bot 2017-02-20 20:46:06 PST 
All reviewed patches have been landed.  Closing bug.