Bug 168536

Summary:

Stop exporting interface WebCoreScrollView on iOS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, juergen, mitz

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	ap: review-, ap: commit-queue-
Updated patch	none
Updated patch	none
Updated patch	none

Aakash Jain

Reported 2017-02-17 15:21:24 PST

WebCoreScrollView in WebKit/mac/WebView/WebHTMLView.mm is unused. This is unused for last 10 years.

Attachments
Proposed patch (1.84 KB, patch) 2017-02-17 15:24 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Proposed patch (1.84 KB, patch) 2017-02-17 15:53 PST, Aakash Jain	ap: review- ap: commit-queue-	Details Formatted Diff Diff
Updated patch (1.51 KB, patch) 2017-02-20 15:38 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (2.44 KB, patch) 2017-02-20 16:01 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (2.48 KB, patch) 2017-02-20 17:16 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-17 15:24:40 PST

Created attachment 301999 [details] Proposed patch

Aakash Jain

Comment 2 2017-02-17 15:53:57 PST

Created attachment 302002 [details] Proposed patch

mitz

Comment 3 2017-02-17 16:27:30 PST

Comment on attachment 302002 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=302002&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:-787 > -// <rdar://problem/4985524> References to WebCoreScrollView as a subview of a WebHTMLView may be present > -// in some NIB files, so NSUnarchiver must be still able to look up this now-unused class. > -@interface WebCoreScrollView : NSScrollView > -@end > - > -@implementation WebCoreScrollView > -@end So we think that those references are only in nib files in apps that no longer need to be supported?

Alexey Proskuryakov

Comment 4 2017-02-17 17:19:04 PST

Let's remove it on iOS only, and keep on Mac. Definitely no risk on iOS.

Aakash Jain

Comment 5 2017-02-20 15:38:54 PST

Created attachment 302183 [details] Updated patch Export the symbol for WebCoreScrollView only for mac.

mitz

Comment 6 2017-02-20 15:55:54 PST

Comment on attachment 302183 [details] Updated patch Can we also move the class definition into the #if !PLATFORM(IOS) section?

Aakash Jain

Comment 7 2017-02-20 16:01:15 PST

Created attachment 302187 [details] Updated patch Moved the class definition into the #if !PLATFORM(IOS) section.

mitz

Comment 8 2017-02-20 17:07:09 PST

Comment on attachment 302187 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=302187&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:781 > +#if PLATFORM(IOS) I think this was meant to be part of the #if !PLATFORM(IOS) section below. This is the opposite!

Aakash Jain

Comment 9 2017-02-20 17:16:18 PST

Created attachment 302208 [details] Updated patch You are right. If condition got reverted somehow. Fixed it now.

WebKit Commit Bot

Comment 10 2017-02-20 20:46:02 PST

Comment on attachment 302208 [details] Updated patch Clearing flags on attachment: 302208 Committed r212697: <http://trac.webkit.org/changeset/212697>

WebKit Commit Bot

Comment 11 2017-02-20 20:46:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.