Bug 168533

Summary:

Font Loading API specifies font is loaded but sizing of font after load reports inconsistent values

Product:

WebKit

Reporter:

Steven Saviano <ssaviano>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, jonlee, koivisto, mmaxfield, rniwa, simon.fraser, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

FromImplementor, InRadar

Version:

Safari 10

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
WIP	none
WIP	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none
Patch	none

Steven Saviano

Reported 2017-02-17 14:37:50 PST

jsfiddle: https://jsfiddle.net/0ko9fLwo/1/ Refresh that page and look at the JS console. It repros via refresh/cmd-R. Steps: 1) Create a new FontFace object with fallbacks in the source string on page load 2) Load the FontFace 3) Add to documents.fonts 4) Monitor sizing of text with the font Expected: Element size stays consistent post FontFace load Actual: Element size has one value and then another post FontFace load. Occurs on: a) Version 10.0.2 (12602.3.12.0.1) b) Release 23 (Safari 10.2, WebKit 12604.1.5) It appears this has to do with fallbacks in the font source strings (and potentially that this is done in the initial page load). If the font source string is only the remote url, then the sizing inconsistency does not occur. https://jsfiddle.net/6eshwbuc/1/

Attachments
WIP (8.46 KB, patch) 2017-03-21 17:58 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (10.51 KB, patch) 2017-03-21 18:16 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (11.21 KB, patch) 2017-03-21 18:21 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (892.85 KB, application/zip) 2017-03-21 19:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews100 for mac-elcapitan (909.09 KB, application/zip) 2017-03-21 19:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.66 MB, application/zip) 2017-03-21 19:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (16.25 MB, application/zip) 2017-03-21 19:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted) 2017-03-21 21:37 PDT, Build Bot	no flags	Details
Patch (13.17 KB, patch) 2017-03-22 11:01 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (13.26 KB, patch) 2017-05-01 14:13 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-02-17 14:50:16 PST

<rdar://problem/30585192>

Myles C. Maxfield

Comment 2 2017-03-21 17:58:34 PDT

Created attachment 305054 [details] WIP

Myles C. Maxfield

Comment 3 2017-03-21 18:16:12 PDT

Created attachment 305056 [details] WIP

Myles C. Maxfield

Comment 4 2017-03-21 18:21:17 PDT

Created attachment 305058 [details] WIP

Build Bot

Comment 5 2017-03-21 19:23:31 PDT

Comment on attachment 305058 [details] WIP Attachment 305058 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3378966 New failing tests: fast/text/web-font-load-fallback-during-loading.html

Build Bot

Comment 6 2017-03-21 19:23:32 PDT

Created attachment 305065 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-03-21 19:29:39 PDT

Comment on attachment 305058 [details] WIP Attachment 305058 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3379005 New failing tests: fast/text/web-font-load-fallback-during-loading.html

Build Bot

Comment 8 2017-03-21 19:29:41 PDT

Created attachment 305066 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-03-21 19:43:22 PDT

Comment on attachment 305058 [details] WIP Attachment 305058 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3378988 New failing tests: fast/text/web-font-load-fallback-during-loading.html

Build Bot

Comment 10 2017-03-21 19:43:24 PDT

Created attachment 305067 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-03-21 19:56:48 PDT

Comment on attachment 305058 [details] WIP Attachment 305058 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3379028 New failing tests: fast/text/web-font-load-fallback-during-loading.html

Build Bot

Comment 12 2017-03-21 19:56:51 PDT

Created attachment 305068 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-03-21 21:37:00 PDT

Comment on attachment 305058 [details] WIP Attachment 305058 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3379446 New failing tests: fast/text/web-font-load-fallback-during-loading.html

Build Bot

Comment 14 2017-03-21 21:37:03 PDT

Created attachment 305072 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 15 2017-03-22 11:01:16 PDT

Created attachment 305111 [details] Patch

Myles C. Maxfield

Comment 16 2017-05-01 14:13:05 PDT

Created attachment 308764 [details] Patch

WebKit Commit Bot

Comment 17 2017-05-02 11:02:54 PDT

Comment on attachment 308764 [details] Patch Clearing flags on attachment: 308764 Committed r216079: <http://trac.webkit.org/changeset/216079>

WebKit Commit Bot

Comment 18 2017-05-02 11:02:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.