Bug 168423 – [GTK] Test fast/shadow-dom/input-element-in-shadow.html is failing in the bots

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

It's failing only because the result has the spell checker underline, while the the reference image doesn't. I don't know why the slot is spell checked and the input in the reference isn't, but we could make the test pass by using real words, since the contents are not important for this test.

[Carlos Garcia Campos]

Created attachment 301747 [details]
Patch

[Michael Catanzaro]

I think you're changing the test to work around a real bug in our text checker. Entering a misspelled word should not trigger a spell checker underline until a separator character (space, period, etc.) is inserted, and this test does not insert such a separator character, so this test should not trigger the spell checker underline.

On the other hand, this test is definitely not intended to test the text checker.

I'll give Ryusuke a chance to review this since shadow DOM is his area, even if the change is trivial.

[Ryosuke Niwa]

Comment on attachment 301747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301747&action=review

> LayoutTests/ChangeLog:10
> +        by using real words, since the contents are not important for this test. Use "one", "two" instead of "abc", "def".

That's because we use eventSender to type in text.
Spellchecker only kicks in for user-typed text

The fix is correct.

[WebKit Commit Bot]

Comment on attachment 301747 [details]
Patch

Clearing flags on attachment: 301747

Committed r212536: <http://trac.webkit.org/changeset/212536>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.