Bug 168372

Summary: webkitpy: Fix DarwinPort._get_crash_log()
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, glenn, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2017-02-15 09:03:46 PST
DarwinPort's implementation of _get_crash_log will cause run-webkit-tests to crash unless classes which inherit from DarwinPort re-implement this function. DarwinPort's implementation of _get_crash_log should be valid, even though it is expected to be re-implemented by inheriting classes.
Attachments
Patch (1.62 KB, patch)
2017-02-15 09:13 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.58 KB, patch)
2017-02-15 11:25 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-02-15 09:04:16 PST
<rdar://problem/30535156>
Jonathan Bedard
Comment 2 2017-02-15 09:13:54 PST
Created attachment 301626 [details] Patch
Daniel Bates
Comment 3 2017-02-15 10:45:13 PST
Comment on attachment 301626 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301626&action=review > Tools/ChangeLog:10 > + crash unless classes which inherit from DarwinPort re-implement this function. What do you by crash? Raise an exception? If so, be specific. Also it is an unwritten convention to wrap ChangeLog lines at around 100 characters
Jonathan Bedard
Comment 4 2017-02-15 11:25:26 PST
Created attachment 301636 [details] Patch for landing
WebKit Commit Bot
Comment 5 2017-02-15 12:02:41 PST
Comment on attachment 301636 [details] Patch for landing Clearing flags on attachment: 301636 Committed r212387: <http://trac.webkit.org/changeset/212387>
WebKit Commit Bot
Comment 6 2017-02-15 12:02:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.