Bug 168324 – [MediaStream] add navigator.getUserMedia for compatibility with legacy content

• Component: Media
• Status: ASSIGNED

[Eric Carlson]

Implement navigator.getUserMedia as a JS built-in for compatibility with legacy content.

[Radar WebKit Bug Importer]

<rdar://problem/30513125>

[Eric Carlson]

Created attachment 301510 [details]
Proposed patch

[youenn fablet]

Comment on attachment 301510 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301510&action=review

> Source/WebCore/ChangeLog:3
> +        [MediaStream] add navigator.getUserMedia for compatibility with legacy content

I am not a big fan of adding it back, but I guess wit is fine aligning to the spec.

> Source/WebCore/Modules/mediastream/MediaDevices.idl:37
> +    [MayThrowException, PrivateIdentifier, PublicIdentifier] Promise<MediaStream> getUserMedia(optional MediaStreamConstraints constraints);

No need for MayThrowException I believe.

> Source/WebCore/Modules/mediastream/NavigatorUserMedia.js:33
> +    // FIXME: We should raise a DOM unsupported exception if there is no navigator and properly detect whether method is not called on a Navigator object.

Ideally, we should fix that by adding @navigator to the global object and @mediaDevices to the Navigator object.
Oh well...

> LayoutTests/ChangeLog:14
> +        * fast/mediastream/webkitGetUserMedia-shadowing-then.html: Added.

Do we want back the disconnected test?

[Build Bot]

Comment on attachment 301510 [details]
Proposed patch

Attachment 301510 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3117276

New failing tests:
fast/dom/navigator-detached-no-crash.html

[Build Bot]

Created attachment 301527 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301510 [details]
Proposed patch

Attachment 301510 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3117338

New failing tests:
fast/dom/navigator-detached-no-crash.html

[Build Bot]

Created attachment 301529 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 301510 [details]
Proposed patch

Attachment 301510 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3117378

New failing tests:
fast/dom/navigator-detached-no-crash.html

[Build Bot]

Created attachment 301530 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Eric Carlson]

Created attachment 301545 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 301545 [details]
Patch for landing.

Clearing flags on attachment: 301545

Committed r212323: <http://trac.webkit.org/changeset/212323>