Summary: | [WebIDL] Improve serializer = { inherit } | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Bindings | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, darin, joepeck, sam | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 168086 | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-02-14 00:53:40 PST
Created attachment 301474 [details]
[PATCH] Proposed Fix
Comment on attachment 301474 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=301474&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1938 > + push(@headerContent, " static JSC::JSObject* serialize(JSC::ExecState*, JS${interfaceName}* thisObject, JSC::ThrowScope&);\n") if $interface->serializable; Can we pass ExecState& and JSXX& instead of pointers? (In reply to comment #2) > Comment on attachment 301474 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301474&action=review > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1938 > > + push(@headerContent, " static JSC::JSObject* serialize(JSC::ExecState*, JS${interfaceName}* thisObject, JSC::ThrowScope&);\n") if $interface->serializable; > > Can we pass ExecState& and JSXX& instead of pointers? Hmm, probably. I'll look at that in a follow-up if I have time. This uses whatever the existing bindings code expects, so I'm going to keep it consistent for now. Thanks for the review! Comment on attachment 301474 [details] [PATCH] Proposed Fix Clearing flags on attachment: 301474 Committed r212344: <http://trac.webkit.org/changeset/212344> All reviewed patches have been landed. Closing bug. |