Bug 168281 – Disabled Media Sources should render black/silence

• Component: Media
• Status: RESOLVED FIXED

[Jer Noble]

Disabled Media Sources should render black/silence

[Jer Noble]

Created attachment 301456 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/30508003>

[Alex Christensen]

Comment on attachment 301456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301456&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:88
> +    if (!m_muted && m_enabled) {
> +        ASSERT(sample.platformSample().type == PlatformSample::CMSampleBufferType);
> +        auto pixelBuffer = static_cast<CVPixelBufferRef>(CMSampleBufferGetImageBuffer(sample.platformSample().sample.cmSampleBuffer));

Do we want muting to affect the pixels?  Is it possible to mute but still send video?

[Jer Noble]

Comment on attachment 301456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301456&action=review

>> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:88
>> +        auto pixelBuffer = static_cast<CVPixelBufferRef>(CMSampleBufferGetImageBuffer(sample.platformSample().sample.cmSampleBuffer));
> 
> Do we want muting to affect the pixels?  Is it possible to mute but still send video?

The spec is explicit: disabling and muting each will cause the source to emit silence or black frames. Muting, here, doesn't necessarily refer to audio.

[Eric Carlson]

Comment on attachment 301456 [details]
Patch

This should have a test.

[Jer Noble]

(In reply to comment #5)
> Comment on attachment 301456 [details]
> Patch
> 
> This should have a test.

Hm, we should be able to render a stream to Web Audio and canvas, where we can verify that only silence/black is rendered.

[Jer Noble]

Created attachment 301533 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 301533 [details]
Patch for landing

Clearing flags on attachment: 301533

Committed r212399: <http://trac.webkit.org/changeset/212399>