Bug 168267

Summary:

[WebRTC] Add support for libwebrtc negotiation needed event

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, commit-queue, eric.carlson, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none
Patch for landing	none

youenn fablet

Reported 2017-02-13 17:18:38 PST

[WebRTC] Add support for libwebrtc negotiation needed event

Attachments
Patch (10.32 KB, patch) 2017-02-14 07:56 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1018.82 KB, application/zip) 2017-02-14 08:57 PST, Build Bot	no flags	Details
Patch (15.14 KB, patch) 2017-02-14 10:57 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (15.23 KB, patch) 2017-02-14 14:48 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-02-14 07:56:40 PST

Created attachment 301501 [details] Patch

Build Bot

Comment 2 2017-02-14 08:57:52 PST

Comment on attachment 301501 [details] Patch Attachment 301501 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3109659 New failing tests: fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html

Build Bot

Comment 3 2017-02-14 08:57:55 PST

Created attachment 301507 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

youenn fablet

Comment 4 2017-02-14 10:57:18 PST

Created attachment 301521 [details] Patch

WebKit Commit Bot

Comment 5 2017-02-14 14:31:48 PST

Comment on attachment 301521 [details] Patch Rejecting attachment 301521 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 301521, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt patching file LayoutTests/platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt patching file LayoutTests/webrtc/negotiatedneeded-event-addStream-expected.txt patching file LayoutTests/webrtc/negotiatedneeded-event-addStream.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3118066

youenn fablet

Comment 6 2017-02-14 14:48:20 PST

Created attachment 301549 [details] Patch for landing

WebKit Commit Bot

Comment 7 2017-02-14 17:25:18 PST

Comment on attachment 301549 [details] Patch for landing Clearing flags on attachment: 301549 Committed r212338: <http://trac.webkit.org/changeset/212338>

WebKit Commit Bot

Comment 8 2017-02-14 17:25:22 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.