Bug 168211

Summary:

Stop compiling our own cursorMovementIterator()

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Text

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, glenn, jfernandez, kondapallykalyan, mmaxfield, rniwa

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=169075

Bug Depends on:

Bug Blocks:

168207, 169075, 182022

Attachments:

Description	Flags
WIP	none
WIP	none
Patch	none
Passes tests	none
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Patch	none
Patch	none
Patch	none
Patch	hyatt: review+

Myles C. Maxfield

Reported 2017-02-12 15:21:48 PST

The platform could provide this.

Attachments
WIP (10.54 KB, patch) 2017-02-13 23:11 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (34.15 KB, patch) 2017-02-16 17:02 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (34.45 KB, patch) 2017-02-17 14:53 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Passes tests (34.57 KB, patch) 2017-02-17 16:15 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (40.52 KB, patch) 2017-02-17 17:58 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (44.18 KB, patch) 2017-02-17 18:16 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (803.47 KB, application/zip) 2017-02-17 19:05 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.79 MB, application/zip) 2017-02-17 19:28 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-elcapitan (1.25 MB, application/zip) 2017-02-17 19:39 PST, Build Bot	no flags	Details
Patch (44.23 KB, patch) 2017-02-17 22:32 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (44.17 KB, patch) 2017-02-17 22:35 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (51.89 KB, patch) 2017-02-18 13:19 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (52.16 KB, patch) 2017-02-20 15:10 PST, Myles C. Maxfield	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-02-13 23:11:00 PST

Created attachment 301465 [details] WIP

Myles C. Maxfield

Comment 2 2017-02-14 21:17:38 PST

editing/deleting/skip-virama-001.html

Myles C. Maxfield

Comment 3 2017-02-16 17:02:23 PST

Created attachment 301860 [details] WIP

Myles C. Maxfield

Comment 4 2017-02-17 14:53:35 PST

Created attachment 301991 [details] Patch

Myles C. Maxfield

Comment 5 2017-02-17 15:45:02 PST

editing/inserting/insert-character-in-first-letter-crash.html fast/text/text-combine-crash.html

Myles C. Maxfield

Comment 6 2017-02-17 16:15:56 PST

Created attachment 302008 [details] Passes tests

Myles C. Maxfield

Comment 7 2017-02-17 17:58:12 PST

Created attachment 302029 [details] Patch

Myles C. Maxfield

Comment 8 2017-02-17 18:16:19 PST

Created attachment 302031 [details] Patch

Build Bot

Comment 9 2017-02-17 19:05:09 PST

Comment on attachment 302031 [details] Patch Attachment 302031 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3146725 New failing tests: editing/caret/emoji.html editing/deleting/delete-emoji.html

Build Bot

Comment 10 2017-02-17 19:05:15 PST

Created attachment 302036 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-02-17 19:28:51 PST

Comment on attachment 302031 [details] Patch Attachment 302031 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3146806 New failing tests: editing/caret/emoji.html editing/deleting/delete-emoji.html

Build Bot

Comment 12 2017-02-17 19:28:57 PST

Created attachment 302038 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-02-17 19:39:34 PST

Comment on attachment 302031 [details] Patch Attachment 302031 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3146892 New failing tests: editing/caret/emoji.html editing/deleting/delete-emoji.html

Build Bot

Comment 14 2017-02-17 19:39:39 PST

Created attachment 302039 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 15 2017-02-17 22:32:54 PST

Created attachment 302047 [details] Patch

Myles C. Maxfield

Comment 16 2017-02-17 22:35:34 PST

Created attachment 302048 [details] Patch

Myles C. Maxfield

Comment 17 2017-02-18 13:19:56 PST

Created attachment 302054 [details] Patch

Myles C. Maxfield

Comment 18 2017-02-20 15:10:51 PST

Created attachment 302178 [details] Patch

Dave Hyatt

Comment 19 2017-02-20 15:23:52 PST

Comment on attachment 302178 [details] Patch r=me Seems a little icky that you had to make NullTextBreakIterator.

Myles C. Maxfield

Comment 20 2017-02-26 16:37:58 PST

Committed r213020: <http://trac.webkit.org/changeset/213020>

Javier Fernandez

Comment 21 2017-03-02 06:13:34 PST

It seems this patch caused a regression, see bug #169075

Daniel Bates

Comment 22 2018-02-18 12:52:17 PST

(In reply to Myles C. Maxfield from comment #20) > Committed r213020: <http://trac.webkit.org/changeset/213020> This regressed selection of text that contains a zero-width joiner character.

Note You need to log in before you can comment on or make changes to this bug.