Bug 168206

Summary: Rename ICU cursor iterator to caret iterator
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: TextAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, dino, esprehn+autocc, glenn, hyatt, jonlee, kondapallykalyan, mmaxfield, rniwa, simon.fraser, thorton, zalan
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168207    
Attachments:
Description Flags
Patch
simon.fraser: review+, commit-queue: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan none

Myles C. Maxfield
Reported 2017-02-12 14:00:48 PST
"Cursor" is the thing you move when you wiggle your mouse.
Attachments
Patch (11.75 KB, patch)
2017-02-26 22:00 PST, Myles C. Maxfield 		simon.fraser: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-elcapitan (956.38 KB, application/zip)
2017-02-26 23:07 PST, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-02-26 22:00:07 PST
Created attachment 302809 [details] Patch
Build Bot
Comment 2 2017-02-26 23:07:13 PST
Comment on attachment 302809 [details] Patch Attachment 302809 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3200333 New failing tests: media/modern-media-controls/volume-down-support/volume-down-support.html
Build Bot
Comment 3 2017-02-26 23:07:18 PST
Created attachment 302820 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Myles C. Maxfield
Comment 4 2017-02-27 00:28:48 PST
Failure is unrelated.
WebKit Commit Bot
Comment 5 2017-02-27 14:41:28 PST
Comment on attachment 302809 [details] Patch Rejecting attachment 302809 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 302809, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 765b17d7ff Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc M Source/WTF/wtf/text/TextBreakIterator.h M Source/WTF/ChangeLog M Source/WebCore/platform/graphics/ComplexTextController.cpp M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/ChangeLog r213093 = a60f7c3133fe46d5826c125c013baa12d578125f (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3204595
Myles C. Maxfield
Comment 6 2017-02-27 14:46:14 PST
Committed r213095: <http://trac.webkit.org/changeset/213095>
Note You need to log in before you can comment on or make changes to this bug.