Summary: | Update isEmojiGroupCandidate() to the latest version of Unicode | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, dino, hyatt, jonlee, mcatanzaro, mitz, mmaxfield, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | Other | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=168199 | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 168207 | ||||||||||||||||
Attachments: |
|
Description
Myles C. Maxfield
2017-02-12 13:46:01 PST
Created attachment 301369 [details]
Patch
Created attachment 301370 [details]
Patch
Created attachment 301423 [details]
Patch
Comment on attachment 301423 [details] Patch Attachment 301423 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3082376 New failing tests: editing/deleting/delete-emoji.html Created attachment 301432 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 301467 [details]
Patch
Comment on attachment 301467 [details] Patch Clearing flags on attachment: 301467 Committed r213499: <http://trac.webkit.org/changeset/213499> All reviewed patches have been landed. Closing bug. Hey Myles, the ICU_HEADERS_UNDERSTAND_SUPPLEMENTAL_SYMBOLS_AND_PICTOGRAPHS case is missing a return statement when if (useSupplementalSymbolsAndPictographs) is false! Bad! [3479/5652] Building CXX object Source...ir/platform/graphics/FontCascade.cpp.o In file included from ../../Source/WebCore/platform/graphics/FontCascade.cpp:27:0: ../../Source/WebCore/platform/text/CharacterProperties.h: In function ‘bool WebCore::isEmojiGroupCandidate(UChar32)’: ../../Source/WebCore/platform/text/CharacterProperties.h:62:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [3483/5652] Building CXX object Source...m/graphics/ComplexTextController.cpp.o In file included from ../../Source/WebCore/platform/graphics/ComplexTextController.cpp:28:0: ../../Source/WebCore/platform/text/CharacterProperties.h: In function ‘bool WebCore::isEmojiGroupCandidate(UChar32)’: ../../Source/WebCore/platform/text/CharacterProperties.h:62:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ [3746/5652] Building CXX object Source...WebCore.dir/rendering/RenderText.cpp.o In file included from ../../Source/WebCore/rendering/RenderText.cpp:31:0: ../../Source/WebCore/platform/text/CharacterProperties.h: In function ‘bool WebCore::isEmojiGroupCandidate(UChar32)’: ../../Source/WebCore/platform/text/CharacterProperties.h:62:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ Problem is... they seem bogus. (In reply to comment #10) > Problem is... they seem bogus. Whoops, I meant to delete that bit of the comment. I at first got confused and didn't notice the problem. litherum: mcatanzaro: the #else should be changed to an #endif Created attachment 303819 [details]
Patch
Comment on attachment 303819 [details] Patch Clearing flags on attachment: 303819 Committed r213616: <http://trac.webkit.org/changeset/213616> All reviewed patches have been landed. Closing bug. |