Bug 168137

Summary: StructureStubInfo::considerCaching() should write barrier its owner CodeBlock when buffering a new Structure.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: ASSIGNED    
Severity: Normal CC: fpizlo, ggaren, jfbastien, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
fpizlo: review+
patch for landing + build fix. none

Mark Lam
Reported 2017-02-10 11:12:47 PST
If we're adding a new structure to StructureStubInfo's bufferedStructures, we should write barrier the StubInfo's owner CodeBlock because that structure may be collected during the next GC. Write barrier-ing the owner CodeBlock ensures that CodeBlock::finalizeBaselineJITInlineCaches() is called on it during the GC, which, in turn, gives the StructureStubInfo the opportunity to filter out the dead structure.
Attachments
proposed patch. (9.43 KB, patch)
2017-02-10 11:24 PST, Mark Lam 		fpizlo: review+
DetailsFormatted DiffDiff
patch for landing + build fix. (9.56 KB, patch)
2017-02-10 11:48 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2017-02-10 11:13:07 PST
<rdar://problem/28656664>
Mark Lam
Comment 2 2017-02-10 11:24:10 PST
Created attachment 301182 [details] proposed patch.
Filip Pizlo
Comment 3 2017-02-10 11:26:00 PST
Comment on attachment 301182 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=301182&action=review Nice. > Source/JavaScriptCore/bytecode/StructureStubInfo.h:2 > - * Copyright (C) 2008, 2012-2016 Apple Inc. All rights reserved. > + * Copyright (C) 2008, 2012-2017 Apple Inc. All rights reserved. I think that we're supposed to write this as "2008-2017".
Mark Lam
Comment 4 2017-02-10 11:48:13 PST
Created attachment 301188 [details] patch for landing + build fix.
Mark Lam
Comment 5 2017-02-10 13:36:43 PST
Thanks for the review. Landed in r212146: <http://trac.webkit.org/r212146>.
Note You need to log in before you can comment on or make changes to this bug.