| Summary: | REGRESSION (r196271): Web Inspector: DOM element loses focus/active selection after committing an inline attribute editor in DOMTreeOutline | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Regressed in http://trac.webkit.org/changeset/196271. This also affects editing DataGridNodes (localStorage). The problem is that these two editing scenarios aren't being handled correctly by WebInspector._focusChanged, which doesn't update the previous/current focus elements when the focus event target is a non-CodeMirror editable field. Non-editable fields (which until http://trac.webkit.org/changeset/196271 included DOM attributes and grid nodes), as well as editable CodeMirror fields, are handled correctly. Created attachment 301222 [details]
Patch
Created attachment 301701 [details]
Patch
Comment on attachment 301701 [details]
Patch
r=me
Comment on attachment 301701 [details] Patch Clearing flags on attachment: 301701 Committed r213689: <http://trac.webkit.org/changeset/213689> All reviewed patches have been landed. Closing bug. |
Created attachment 301162 [details] [VIDEO] Steps to reproduce: 1. Inspect Element 2. Press Enter to edit the first attribute of the element 3. Press Enter again to commit the unedited attribute value => DOM attribute has focus ring, but loses active selection 4. Further 'Enter' keypresses should edit/commit the attribute => Nothing happens