Bug 168091 – [macOS debug] LayoutTest inspector/worker/resources-in-worker.html is a flaky timeout

• Component: Web Inspector
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest inspector/worker/resources-in-worker.html is a flaky timeout

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r211994%20(10938)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fworker%2Fresources-in-worker.html

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/212006

[Matt Lewis]

The test appears to no longer be timing out but rather the test is now a flaky failure on macOS Release

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r225599%20(1589)/results.html

diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/inspector/worker/resources-in-worker-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/inspector/worker/resources-in-worker-actual.txt
@@ -1,64 +1,13 @@
-CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: TypeError: The requested URL was not found on this server.
 Test for Resources in a Worker.
 
 
 == Running test suite: Worker.Resources
 -- Running test case: Worker.Resource.Start
-PASS: Added Target should have Worker type.
+-- Running test case: Worker.Resource.XHR
+!! EXCEPTION: null is not an object (evaluating 'workerTarget.resourceCollection')
+Stack Trace: #0: (anonymous) (test)
+#1: initializePromise [native code]
+#2: Promise [native code]
+#3: (anonymous) (TestCombined.js:1454:35)
+#4: promiseReactionJob [native code]
 
--- Running test case: Worker.Resource.XHR
-PASS: Worker Target should have 1 resource.
-PASS: Worker Target should dispatch ResourceAdded event.
-PASS: Resource should be XHR.
-PASS: Resource should be tied to the Worker Target.
-PASS: Resource has no parent frame.
-PASS: Worker Target should have 2 resources.
-RESOURCES:
-inspector/worker/resources/resource-utilities.js
-inspector/worker/resources/dataXHR.json
-
--- Running test case: Main.Resource.XHR
-PASS: Worker Target should still have 2 resources.
-PASS: Frame should dispatch ResourceWasAdded event.
-PASS: Resource should be XHR.
-PASS: Resource should be tied to the Main Target.
-PASS: Resource parentFrame is the main frame.
-PASS: Worker Target should still have 2 resources.
-RESOURCES:
-inspector/worker/resources/resource-utilities.js
-inspector/worker/resources/dataXHR.json
-
--- Running test case: Worker.Resource.Fetch
-PASS: Worker Target should have 2 resources.
-PASS: Worker Target should dispatch ResourceAdded event.
-PASS: Resource should be tied to the Worker Target.
-PASS: Resource has no parent frame.
-PASS: Worker Target should have 3 resources.
-RESOURCES:
-inspector/worker/resources/resource-utilities.js
-inspector/worker/resources/dataXHR.json
-inspector/worker/resources/dataFetch.json
-
--- Running test case: Main.Resource.Fetch
-PASS: Worker Target should still have 3 resources.
-PASS: Frame should dispatch ResourceWasAdded event.
-PASS: Resource should be tied to the Main Target.
-PASS: Resource parentFrame is the main frame.
-PASS: Worker Target should still have 3 resources.
-RESOURCES:
-inspector/worker/resources/resource-utilities.js
-inspector/worker/resources/dataXHR.json
-inspector/worker/resources/dataFetch.json
-
--- Running test case: Worker.Resource.ImportScript
-PASS: Worker Target should still have 3 resources.
-PASS: Worker Target should dispatch ResourceAdded event.
-PASS: Resource should be tied to the Worker Target.
-PASS: Resource has no parent frame.
-PASS: Worker Target should have 4 resources.
-RESOURCES:
-inspector/worker/resources/resource-utilities.js
-inspector/worker/resources/dataXHR.json
-inspector/worker/resources/dataFetch.json
-inspector/worker/resources/worker-import-1.js
-

Adjusted Expectations in:
https://trac.webkit.org/changeset/225612/webkit

[Joseph Pecoraro]

*** Bug 175661 has been marked as a duplicate of this bug. ***

[Joseph Pecoraro]

Created attachment 346945 [details]
[PATCH] Proposed Fix

[EWS Watchlist]

Comment on attachment 346945 [details]
[PATCH] Proposed Fix

Attachment 346945 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8824452

New failing tests:
inspector/dom-debugger/xhr-breakpoints.html

[EWS Watchlist]

Created attachment 346948 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346945 [details]
[PATCH] Proposed Fix

Attachment 346945 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8824473

New failing tests:
inspector/dom-debugger/xhr-breakpoints.html

[EWS Watchlist]

Created attachment 346949 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Joseph Pecoraro]

Created attachment 346950 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 346950 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=346950&action=review

r=me

> LayoutTests/ChangeLog:8
> +        * inspector/worker/resources-in-worker-expected.txt:

Missing ChangeLog entries:
 * inspector/dom-debugger/resources/dataXHR.json: Added.
 * inspector/dom-debugger/xhr-breakpoints.html:

> LayoutTests/inspector/worker/resources-in-worker.html:61
> +                if (workerIsReady && workerTargetIsSet)

Just as a thought, you could use two `WI.WrappedPromise` here and have the test finish using `Promise.all([...]).then(resolve, reject);` or even make it async and use await.

[Joseph Pecoraro]

> > LayoutTests/ChangeLog:8
> > +        * inspector/worker/resources-in-worker-expected.txt:
> 
> Missing ChangeLog entries:
>  * inspector/dom-debugger/resources/dataXHR.json: Added.
>  * inspector/dom-debugger/xhr-breakpoints.html:

Oops, I added these after the fact and forgot to git add~


> > LayoutTests/inspector/worker/resources-in-worker.html:61
> > +                if (workerIsReady && workerTargetIsSet)
> 
> Just as a thought, you could use two `WI.WrappedPromise` here and have the
> test finish using `Promise.all([...]).then(resolve, reject);` or even make
> it async and use await.

I considered it but this was nice and simple =)

[Joseph Pecoraro]

https://trac.webkit.org/changeset/234821/webkit

[Radar WebKit Bug Importer]

<rdar://problem/43256072>