Bug 168067

Summary:

[WebIDL] Cleanup XMLHttpRequest's bindings

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Patch	none

Sam Weinig

Reported 2017-02-09 13:04:04 PST

[WebIDL] Cleanup XMLHttpRequest's bindings

Attachments
Patch (15.75 KB, patch) 2017-02-09 13:06 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.41 MB, application/zip) 2017-02-09 14:09 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.40 MB, application/zip) 2017-02-09 14:27 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (792.77 KB, application/zip) 2017-02-09 15:00 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews103 for mac-elcapitan (1.01 MB, application/zip) 2017-02-09 16:01 PST, Build Bot	no flags	Details
Patch (21.36 KB, patch) 2017-02-10 17:45 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-02-09 13:06:15 PST

Created attachment 301075 [details] Patch

Build Bot

Comment 2 2017-02-09 14:09:16 PST

Comment on attachment 301075 [details] Patch Attachment 301075 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3051864 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm http/tests/xmlhttprequest/set-bad-headervalue.html imported/w3c/web-platform-tests/XMLHttpRequest/open-url-encoding.htm imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name.htm

Build Bot

Comment 3 2017-02-09 14:09:19 PST

Created attachment 301082 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-02-09 14:26:58 PST

Comment on attachment 301075 [details] Patch Attachment 301075 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3051936 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm http/tests/xmlhttprequest/set-bad-headervalue.html imported/w3c/web-platform-tests/XMLHttpRequest/open-url-encoding.htm imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name.htm

Build Bot

Comment 5 2017-02-09 14:27:02 PST

Created attachment 301085 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-02-09 15:00:14 PST

Comment on attachment 301075 [details] Patch Attachment 301075 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3052773 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm http/tests/xmlhttprequest/set-bad-headervalue.html imported/w3c/web-platform-tests/XMLHttpRequest/open-url-encoding.htm imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name.htm

Build Bot

Comment 7 2017-02-09 15:00:18 PST

Created attachment 301089 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-02-09 16:01:07 PST

Comment on attachment 301075 [details] Patch Attachment 301075 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3053056 New failing tests: imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm http/tests/xmlhttprequest/set-bad-headervalue.html imported/w3c/web-platform-tests/XMLHttpRequest/open-url-encoding.htm imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name.htm

Build Bot

Comment 9 2017-02-09 16:01:11 PST

Created attachment 301095 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 10 2017-02-10 17:45:10 PST

Created attachment 301225 [details] Patch

Chris Dumez

Comment 11 2017-02-10 20:21:28 PST

Comment on attachment 301225 [details] Patch r=me

WebKit Commit Bot

Comment 12 2017-02-10 21:50:58 PST

Comment on attachment 301225 [details] Patch Clearing flags on attachment: 301225 Committed r212181: <http://trac.webkit.org/changeset/212181>

WebKit Commit Bot

Comment 13 2017-02-10 21:51:03 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.