Bug 168013

Summary: Promote JSContext.allowsRemoteInspection from SPI to API
Product: WebKit Reporter: Blaze Burg <bburg>
Component: JavaScriptCoreAssignee: Blaze Burg <bburg>
Status: NEW    
Severity: Normal CC: andersca, bburg, commit-queue, fpizlo, ggaren, joepeck, keith_miller, mark.lam, mjs, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 mjs: review-

Blaze Burg
Reported 2017-02-08 11:57:29 PST
<rdar://problem/29764545>
Attachments
Patch (3.40 KB, patch)
2017-02-16 16:24 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Patch v2 (6.18 KB, patch)
2017-02-16 16:50 PST, Blaze Burg 		mjs: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-02-16 16:24:01 PST
Created attachment 301853 [details] Patch
Joseph Pecoraro
Comment 2 2017-02-16 16:33:23 PST
Comment on attachment 301853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301853&action=review > Source/JavaScriptCore/API/JSContext.h:187 > +@property BOOL remoteInspectionEnabled NS_AVAILABLE(10_13, 11_0); The equivalent C APIs, should move from JSContextRefPrivate.h to JSContextRef.h. JSGlobalContextGetRemoteInspectionEnabled JSGlobalContextSetRemoteInspectionEnabled I don't know what to do about their availability macros.
Blaze Burg
Comment 3 2017-02-16 16:50:33 PST
Created attachment 301857 [details] Patch v2
Maciej Stachowiak
Comment 4 2020-05-30 18:05:27 PDT
Comment on attachment 301857 [details] Patch v2 This seems like a good idea, and I'm surprised this is still SPI. But the patch no longer applies as-is, so r- for that.
Note You need to log in before you can comment on or make changes to this bug.