| Summary: | Remove most cases of #if ENABLE(CACHE_PARTITIONING) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | beidson | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antti Koivisto
2017-02-08 08:14:47 PST
Created attachment 300901 [details]
patch
Comment on attachment 300901 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=300901&action=review I love this! rs=me when you get it compiling. > Source/WebCore/loader/FrameLoader.cpp:1204 > request.setDomainForCachePartition(m_frame.tree().top().document()->securityOrigin().domainForCachePartition()); Should this be using topOrigin? > Source/WebCore/loader/cache/MemoryCache.cpp:562 > static NeverDestroyed<String> httpString("http"); This can't really be necessary now that we have ASCIILiteral, right? > Source/WebCore/platform/network/ResourceRequestBase.cpp:665 > +#else > + return domain; > +#endif Is this the right decision? Maybe we should we just return emptyString() if there is no PUBLIC_SUFFIX_LIST support? Or maybe we should #error if you enable ENABLE(CACHE_PARTITIONING) without ENABLE(PUBLIC_SUFFIX_LIST)? > Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:97 > + > > revalidationRequest.makeUnconditional(); No need for this extra newline. Created attachment 301023 [details]
patch
Created attachment 301026 [details]
patch
|