Bug 167958

Summary:

Split JSDOMConstructor.h/cpp up by class

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Patch	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch	none

Sam Weinig

Reported 2017-02-07 14:11:53 PST

Split JSDOMConstructor.h/cpp up by class

Attachments
Patch (240.57 KB, patch) 2017-02-07 14:25 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews112 for mac-elcapitan (2.17 MB, application/zip) 2017-02-07 15:31 PST, Build Bot	no flags	Details
Patch (256.21 KB, patch) 2017-02-07 18:25 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews115 for mac-elcapitan (1.89 MB, application/zip) 2017-02-07 19:44 PST, Build Bot	no flags	Details
Patch (256.11 KB, patch) 2017-02-08 09:00 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-02-07 14:25:06 PST

Created attachment 300852 [details] Patch

WebKit Commit Bot

Comment 2 2017-02-07 14:26:40 PST

Attachment 300852 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMConstructorNotConstructable.h:40: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMBuiltinConstructor.h:41: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/js/JSDOMNamedConstructor.h:39: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 3 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2017-02-07 15:31:12 PST

Comment on attachment 300852 [details] Patch Attachment 300852 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3021806 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-02-07 15:31:15 PST

Created attachment 300856 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 5 2017-02-07 18:25:00 PST

Created attachment 300872 [details] Patch

Build Bot

Comment 6 2017-02-07 19:44:36 PST

Comment on attachment 300872 [details] Patch Attachment 300872 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3022727 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2017-02-07 19:44:39 PST

Created attachment 300878 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 8 2017-02-08 09:00:44 PST

Created attachment 300908 [details] Patch

Tim Horton

Comment 9 2017-02-08 12:00:23 PST

Comment on attachment 300908 [details] Patch rs=me

WebKit Commit Bot

Comment 10 2017-02-08 12:26:11 PST

Comment on attachment 300908 [details] Patch Clearing flags on attachment: 300908 Committed r211892: <http://trac.webkit.org/changeset/211892>

WebKit Commit Bot

Comment 11 2017-02-08 12:26:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.