Bug 167958

Summary: Split JSDOMConstructor.h/cpp up by class
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
Patch
none
Archive of layout-test-results from ews115 for mac-elcapitan
none
Patch none

Description Sam Weinig 2017-02-07 14:11:53 PST
Split JSDOMConstructor.h/cpp up by class
Comment 1 Sam Weinig 2017-02-07 14:25:06 PST
Created attachment 300852 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-07 14:26:40 PST
Attachment 300852 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConstructorNotConstructable.h:40:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBuiltinConstructor.h:41:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMNamedConstructor.h:39:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
Total errors found: 3 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2017-02-07 15:31:12 PST
Comment on attachment 300852 [details]
Patch

Attachment 300852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3021806

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-02-07 15:31:15 PST
Created attachment 300856 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Sam Weinig 2017-02-07 18:25:00 PST
Created attachment 300872 [details]
Patch
Comment 6 Build Bot 2017-02-07 19:44:36 PST
Comment on attachment 300872 [details]
Patch

Attachment 300872 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3022727

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-02-07 19:44:39 PST
Created attachment 300878 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Sam Weinig 2017-02-08 09:00:44 PST
Created attachment 300908 [details]
Patch
Comment 9 Tim Horton 2017-02-08 12:00:23 PST
Comment on attachment 300908 [details]
Patch

rs=me
Comment 10 WebKit Commit Bot 2017-02-08 12:26:11 PST
Comment on attachment 300908 [details]
Patch

Clearing flags on attachment: 300908

Committed r211892: <http://trac.webkit.org/changeset/211892>
Comment 11 WebKit Commit Bot 2017-02-08 12:26:16 PST
All reviewed patches have been landed.  Closing bug.