Summary: | Split JSDOMConstructor.h/cpp up by class | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ap, commit-queue | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-02-07 14:11:53 PST
Created attachment 300852 [details]
Patch
Attachment 300852 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSDOMConstructorNotConstructable.h:40: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBuiltinConstructor.h:41: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMNamedConstructor.h:39: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
Total errors found: 3 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 300852 [details] Patch Attachment 300852 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3021806 Number of test failures exceeded the failure limit. Created attachment 300856 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 300872 [details]
Patch
Comment on attachment 300872 [details] Patch Attachment 300872 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3022727 Number of test failures exceeded the failure limit. Created attachment 300878 [details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 300908 [details]
Patch
Comment on attachment 300908 [details]
Patch
rs=me
Comment on attachment 300908 [details] Patch Clearing flags on attachment: 300908 Committed r211892: <http://trac.webkit.org/changeset/211892> All reviewed patches have been landed. Closing bug. |