Summary: | [GStreamer] Deadlock when media player is destroyed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Bastien Nocera <bugzilla> | ||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Bastien Nocera
2017-02-05 17:12:43 PST
This is a deadlock, main thread in webkitVideoSinkUnlock while compositing thread is in webkitVideoSinkRender. I think I fixed this in r211357. I tried to reproduce this the other day in trunk and I was unable. (In reply to comment #1) > This is a deadlock, main thread in webkitVideoSinkUnlock while compositing > thread is in webkitVideoSinkRender. I think I fixed this in r211357. I tried > to reproduce this the other day in trunk and I was unable. Is that version in the release I'm using? Or should I ask Michael to backport it? (In reply to comment #2) > (In reply to comment #1) > > This is a deadlock, main thread in webkitVideoSinkUnlock while compositing > > thread is in webkitVideoSinkRender. I think I fixed this in r211357. I tried > > to reproduce this the other day in trunk and I was unable. > > Is that version in the release I'm using? Or should I ask Michael to > backport it? What release are you using? It's in 2.15.4, but not in 2.14.3. If you are using 2.15.4 then it's not fixed. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > This is a deadlock, main thread in webkitVideoSinkUnlock while compositing > > > thread is in webkitVideoSinkRender. I think I fixed this in r211357. I tried > > > to reproduce this the other day in trunk and I was unable. > > > > Is that version in the release I'm using? Or should I ask Michael to > > backport it? > > What release are you using? It's in 2.15.4, but not in 2.14.3. If you are > using 2.15.4 then it's not fixed. Comment 0 :) I'm using 2.14.3 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > This is a deadlock, main thread in webkitVideoSinkUnlock while compositing > > > > thread is in webkitVideoSinkRender. I think I fixed this in r211357. I tried > > > > to reproduce this the other day in trunk and I was unable. > > > > > > Is that version in the release I'm using? Or should I ask Michael to > > > backport it? > > > > What release are you using? It's in 2.15.4, but not in 2.14.3. If you are > > using 2.15.4 then it's not fixed. > > Comment 0 :) > > I'm using 2.14.3 phew, then maybe it's indeed fixed by r211357. I plan to make 2.14.4 this week including that fix. (In reply to comment #2) > Is that version in the release I'm using? Or should I ask Michael to > backport it? Carlos handles all the backports! Anyway, I'm going to close this since it's already on the backports list and we think it's fixed in trunk. If you can reproduce in 2.14.4 once that's released, then we are wrong, so please complain or reopen in that case. <KaL> hadess: deadlock is still here :-/ I think i have a fix <KaL> feel free to reopen the bug I finally managed to reliably reproduce this with yelp :-) And the problem is that we are calling notifyDone() for the draw mutex without taking the lock. Created attachment 300801 [details]
Patch
Committed r211815: <http://trac.webkit.org/changeset/211815> |