Bug 167834 – Playback stalls when a SourceBuffer append causes frame eviction

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Playback stalls when a SourceBuffer append causes frame eviction

[Jer Noble]

<rdar://problem/30107622>

[Jer Noble]

Created attachment 300611 [details]
Patch

[WebKit Commit Bot]

Attachment 300611 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebCore/SampleMap.cpp:51:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/SampleMap.cpp:64:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/SampleMap.cpp:69:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/SampleMap.cpp:98:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: PerformanceTests/MediaTime/main.cpp:26:  Streams are highly discouraged.  [readability/streams] [3]
ERROR: PerformanceTests/MediaTime/main.cpp:27:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: PerformanceTests/MediaTime/main.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: PerformanceTests/MediaTime/main.cpp:51:  sq_sum is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: PerformanceTests/MediaTime/main.cpp:77:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: PerformanceTests/MediaTime/main.cpp:76:  Missing space before ( in switch(  [whitespace/parens] [5]
ERROR: Source/WTF/wtf/MediaTime.cpp:389:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 11 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Created attachment 300612 [details]
Patch

[Jer Noble]

Created attachment 300613 [details]
MediaTime-pre.txt

[Jer Noble]

Created attachment 300614 [details]
MediaTime-post.txt

[Jer Noble]

Created attachment 300615 [details]
MSERemoveCodedFrames-pre.txt

[Jer Noble]

Created attachment 300616 [details]
MSERemoveCodedFrames-post.txt

[Jer Noble]

Performance testing shows a 250% speed increase in comparing uniform MediaTime values (see MediaTime-pre/post.txt) and and 150% speed increase in appending and removing media data from SourceBuffers.

[WebKit Commit Bot]

Comment on attachment 300612 [details]
Patch

Clearing flags on attachment: 300612

Committed r211746: <http://trac.webkit.org/changeset/211746>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.